Interact menu - Fix condition in consolidated menu

[Dystopian]

When merged this pull request will:

• title.

Currently consolidated menu runs original condition code before statement but with child custom params. This can lead to error when child params are different to parent params.

Thanks @mrschick for another pointing to problem in #9876.

_insertChildrenChild changes are made just for consistency. In fact it can be replaced with {} because it looks like it's never used after fnc_collectActiveActionTree.

I don't know why this wasn't implemented in #8060 :-(

[LinkIsGrim]

lgtm?

[PabstMirror]

test code

_condition = {
    systemChat format ["C1 Cond %1",_this#2];
    true
};
_statement = {};
_insert = {
    _subAction = ["C2","C2","",{systemChat format ["C2 %1",_this#2];},{systemChat format ["C2 Cond %1",_this#2]; true}, {}, ["222"]] call ace_interact_menu_fnc_createAction;
    [[_subAction, [], player]]
};
_action = ["C1","C1","",_statement,_condition, _insert, ["111"]] call ace_interact_menu_fnc_createAction;
[(typeOf player), 1, ["ACE_SelfActions"], _action] call ace_interact_menu_fnc_addActionToClass;

prints out C1 Cond ["222"]
and this PR fixes the issue

[PabstMirror]

a similar bug also exists with reordering
https://github.com/acemod/ACE3/blob/master/addons/interact_menu/functions/fnc_initMenuReorder.sqf#L32-L36
private _conditionFullString = format ["%1 && {%2}", _parentConditionString, _condition call EFUNC(common,codeToString)];
will call child and parent with the child's params
but I really don't see this being a problem because params are almost exclusively used with dynamic children and wouldn't be show as re-orderable, I think?

[Dystopian]

params are almost exclusively used with dynamic children and wouldn't be show as re-orderable

I found only 2 related self-actions:

1. Artillery Tables

   ACE3/addons/artillerytables/functions/fnc_interactMenuOpened.sqf

   Line 103 in a12ad9e

   [ace_player, 1, ["ACE_SelfActions", "ACE_Equipment"], _action] call EFUNC(interact_menu,addActionToObject);

   
   It uses Equipment as parent which has true condition:

   ACE3/addons/interaction/CfgVehicles.hpp

   Lines 321 to 323 in a12ad9e

   	class ACE_Equipment {
   	displayName = CSTRING(Equipment);
   	condition = QUOTE(true);

   
   Also these actions are loaded after settings created so no problem here at all.

2. Medical GUI

   ACE3/addons/medical_gui/functions/fnc_addTreatmentActions.sqf

   Line 63 in a12ad9e

   GVAR(selfInteractionActions) pushBack ["", 1, ["ACE_SelfActions", "ACE_Medical", _actionPath], _action];

   
   which uses Medical parent with setting in condition

   ACE3/addons/medical_gui/CfgVehicles.hpp

   Lines 5 to 7 in a12ad9e

   	class ACE_Medical {
   	displayName = CSTRING(Medical);
   	condition = QGVAR(enableSelfActions);

   
   and true in subactions

   ACE3/addons/medical_gui/CfgVehicles.hpp

   Line 12 in a12ad9e

   #define ACTION_CONDITION condition = "true";

So yes I also don't see a problem with reordering.

But I found a bug: reordered Equipment menu has no artillery tables. I'm working on it.