-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Towing - Fix some issues #9007
Towing - Fix some issues #9007
Conversation
Ready for review. I didn't find a way to fix possible rope attachment inside vehicles resulting impossible to detach it. I added parent hook as partial workaround but if anybody knows a better way to fix please tell me. |
After #8963 and this PR rope can also be added to boats inventory. I can't really decide if it's needed. |
To fix possible rope attachment inside vehicles resulting impossible to detach it I added I tested towing helicopters with enabled AFM and it works OK as with disabled one. But I disabled towed helicopters because I don't think helicopters have suitable towing points (except landing gear maybe). Naturally this can be discussed. I added rope to boats inventory because it looks quite appropriate. |
/* | ||
* Author: Dystopian | ||
* Attaches child to parent vehicle. | ||
* Run globally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be much better if the fnc did the 'Run globally' parts for themselves automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't get you. Do you mean I should replace one global event and one function with 3 events and its own functions (1 for parent owner, 1 global setTowParent
run and 1 for server)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean the script is changed to Must be run on the server
and the Server runs it globally, otherwise remoteExec
ed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still can't understand how it could be better to move script executing to server and split 1 global event to 3 events (1 of those is global anyway) and functions. In any case we have to run globally setTowParent
part. I don't see any profit from function splitting.
…3 into towing-fix-attach-on-click
Whats the status on this? We had several Issues in our last OP that would probably all be fixed with this PR. |
This PR is quite large and should be tested well by ACE devs. So we have to wait with patience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested it yet, but I will soon.
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Also hoping to see this PR go through. Towing is completely inop in both singleplayer and multiplayer in 3.16 |
🍌 |
When merged this pull request will:
and helicopters;Detach
actions to both towing/towed vehicle;Attach tow rope
menu if player is close to vehicle;Multiple towing means either several ropes between parent and child or one parent with several children one by one and parallel.
setTowParent
is not JIP compatible so I added workaround.It turned out that ships can tow and can be towed, helicopters can be towed as well (at least those with wheels).
With parent hook rope can be detached from parent too.
Current hook model glows very much. This can be a problem at night when you want to hide vehicles. I didn't find more suitable model and used empty one which is OK. There is
\A3\Data_f\Hook\Hook_F.p3d
which is good but it could be weird for many vehicles.ropeAttachTo
andropeDetach
commands must be run where parent and rope are local.setTowParent
must be run on all clients.Current implementation runs
Deleted
andRopeBreak
EHs on client where rope was attached. When client disconnects EHs aren't triggered. The PR fixes it.