Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical - Change default spontaneous wake up chance & epinephrine boost settings #9241

Merged

Conversation

LinkIsGrim
Copy link
Contributor

When merged this pull request will:

  • Title.

Epinephrine does nothing with default settings. This is counter-productive for understanding of that mechanic.

Some math for unconsciousness: on average, a stable, unconscious patient will take 3.5 minutes (0.95^14) to reach 50% chance to wake up. Bell curve means this will usually be higher. Setting to 10% halves this without making things easy.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@PabstMirror
Copy link
Contributor

ref #7076
this was added more for gameplay reasons than realism
i'm not against this but we should be careful about changing default settings now

imho default settings lead to brutal wake up times,
but most people have probably changed their settings to what they want

@LinkIsGrim LinkIsGrim added the kind/cleanup Release Notes: **CHANGED:** label Jul 9, 2023
@LinkIsGrim LinkIsGrim added kind/change Release Notes: **CHANGED:** and removed kind/cleanup Release Notes: **CHANGED:** labels Sep 13, 2024
@johnb432 johnb432 self-requested a review September 14, 2024 06:24
Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imho default settings lead to brutal wake up times,

Agreed, which is why imo we should change it.

@PabstMirror PabstMirror added this to the 3.18.0 milestone Sep 20, 2024
@LinkIsGrim LinkIsGrim merged commit bb058cd into acemod:master Sep 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/change Release Notes: **CHANGED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants