Common - Add FUNC(doArtilleryFire)
#9260
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
function looks good, but I don't think it belongs in artillerytables, probably just csw? |
|
If not Artillery Tables then I'd move this to Common. Maybe just move the CSW handling to a separate function in CSW and keep this in Artillery Tables? |
LinkIsGrim
changed the title
FUNC(doArtilleryFire)FUNC(doArtilleryFire)
LinkIsGrim
commented
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
doArtilleryFire. Handles CSW magazines, reloading, and barrage sizes larger than the magazine.Loop comes from here.
Relevant files are
FUNC(doArtilleryFire)andFUNC(handleDoArtilleryFire).Requires #9234 (and ideally #9238).
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.