Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical - Fix broken AI ragdolls if AI unconsciousness is disabled #9917

Merged
merged 6 commits into from
Apr 7, 2024

Conversation

LinkIsGrim
Copy link
Contributor

@LinkIsGrim LinkIsGrim commented Apr 3, 2024

When merged this pull request will:

@LinkIsGrim LinkIsGrim added the kind/bug-fix Release Notes: **FIXED:** label Apr 3, 2024
@LinkIsGrim LinkIsGrim added this to the 3.17.1 milestone Apr 3, 2024
Co-authored-by: jonpas <jonpas33@gmail.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>

// Prevent second ragdoll of uncon units when they're killed
if (
IS_UNCONSCIOUS(_unit) && !isAwake _unit // uncon and not ragdolling
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny that the isAwake _unit ain't lazy-evaled but isPlayer _unit is, like next to all (if not all) others in the mod.

Copy link
Member

@Mike-MF Mike-MF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with/without AI unconsciousness, no delay or other weird behaviour. Works as expected again.

@LinkIsGrim LinkIsGrim merged commit 6a2f3a2 into master Apr 7, 2024
5 checks passed
@LinkIsGrim LinkIsGrim deleted the fix-ai-uncon branch April 7, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Medical Engine] AI freeze when killed when AI unconcious is disabled
6 participants