Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUP Compat - Fix NVG Black/Green translations #9976

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Conversation

PabstMirror
Copy link
Contributor

ref #9975

@PabstMirror PabstMirror added the ignore-changelog Release Notes: Excluded label Apr 26, 2024
@PabstMirror PabstMirror added this to the 3.17.1 milestone Apr 26, 2024
@jonpas jonpas changed the title cup compat - fix nvg black/green translations CUP Compat - Fix NVG Black/Green translations Apr 26, 2024
@jonpas jonpas added kind/translation Release Notes: **TRANSLATIONS:** kind/bug-fix Release Notes: **FIXED:** labels Apr 26, 2024
Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just taken a look at nightvision's stringtable - it's inconsistent, just like here, when it comes to color capitalisation.
In German, do we want to capitalise the colour or not?

@PabstMirror
Copy link
Contributor Author

I think I originally made these nvg translations by piecing together cup and vanilla words
vanilla stringtables are inconsistent

            <Key ID="str_a3_cfgglasses_g_shades_green0">
              <Original>Shades (Green)</Original>
              <Chinese>太陽眼鏡(綠)</Chinese>
              <French>Lun. soleil (vertes)</French>
              <Spanish>Sombras (rojo)</Spanish>
              <Italian>Occhiali da sole (verdi)</Italian>
              <Polish>Okulary przeciwsłoneczne (zielone)</Polish>
              <Russian>Светофильтр (зеленый)</Russian>
              <German>Sonnenbrille (grün)</German>
              <Czech>Zrcadlovky (zelené)</Czech>
              <English>Shades (Green)</English>
              <Portuguese>Tons (Verde)</Portuguese>
              <Korean>셰이드(녹색)</Korean>
              <Chinesesimp>太阳镜(绿色)</Chinesesimp>
              <Japanese>サングラス(緑)</Japanese>
              <Turkish>Güneş Gözlüğü (Yeşil)</Turkish>

@PabstMirror PabstMirror merged commit 9d16875 into master Apr 30, 2024
5 checks passed
@PabstMirror PabstMirror deleted the cupNvgSwapColors branch April 30, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-changelog Release Notes: Excluded kind/bug-fix Release Notes: **FIXED:** kind/translation Release Notes: **TRANSLATIONS:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants