Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation - Add Missing German #9975

Merged
merged 12 commits into from
Jun 9, 2024
Merged

Translation - Add Missing German #9975

merged 12 commits into from
Jun 9, 2024

Conversation

Nilia119
Copy link
Contributor

@Nilia119 Nilia119 commented Apr 26, 2024

Add Missing German Translation and improved it.

While I did that, I discovered something:
Unbenannt
According to the Stringtext (in addons/compat_cup_weapons/compat_cup_weapons_nightvision/stringtable.xml) the NVG is supposed to be Green, but almost in all translation it is titled as "Black" German included (except for Russian [I don't know about the Chinese/Korean/Japan one, i can't read that xD]).
I would change that accordingly.
Have a nice day!

addons/arsenal/stringtable.xml Outdated Show resolved Hide resolved
addons/common/stringtable.xml Outdated Show resolved Hide resolved
addons/common/stringtable.xml Outdated Show resolved Hide resolved
Nilia119 and others added 2 commits April 26, 2024 11:54
Co-authored-by: BaerMitUmlaut <BaerMitUmlaut@users.noreply.github.com>
Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My German isn't the best, so take everything with a grain of salt.

@Nilia119
Copy link
Contributor Author

My German isn't the best, so take everything with a grain of salt.

All input is good :D. Sometimes you can't see the forest for the trees xD.

@PabstMirror PabstMirror added the kind/translation Release Notes: **TRANSLATIONS:** label May 2, 2024
@PabstMirror PabstMirror added this to the 3.18.0 milestone May 2, 2024
@Nilia119
Copy link
Contributor Author

Do you mind merging this?
I was hoping, the translations would be in the next update.
I really really really hate having to resolve conflicts. Not only that, but I changed everything, which was requested, sucks this is lying here for three weeks now... I won't fix any more conflicts. Thank you!

@PabstMirror PabstMirror merged commit d66c390 into acemod:master Jun 9, 2024
5 checks passed
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
* Added Missing German Translation

* Improved German Translation

* Update Medical_treatment

* Update Medical_treatment stringtable.xml

* Update addons/common/stringtable.xml

Co-authored-by: BaerMitUmlaut <BaerMitUmlaut@users.noreply.github.com>

* Update stringtable.xml

* Update stringtable.xml

* Update stringtable.xml

* Update stringtable.xml

* Update addons/arsenal/stringtable.xml

---------

Co-authored-by: BaerMitUmlaut <BaerMitUmlaut@users.noreply.github.com>
Co-authored-by: Mike-MF <TyroneMF@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/translation Release Notes: **TRANSLATIONS:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants