Vehicle quick mount #29

jameslkingsley · 2016-07-11T18:41:53Z

When merged this pull request will:

Add the quick-mount keybind that when pressed will mount the player into the vehicle based on direction and distance

The idea of this module is to provide a fail-safe for when action menus fail to appear when you're trying to quickly mount a vehicle. An example is when you're running towards an extraction helicopter and you're unable to get in when in real life you know you should be able to.

It works by drawing a line from the players camera direction, projected X meters forward. It then picks the nearest vehicle from that list and moves on to the get-in code.

Demonstration: https://www.youtube.com/watch?v=3LWhYdG02xQ

Detect nearest eligible vehicle based on distance and direction of player
Move player into an empty vehicle position (priority order: driver, gunner, commander, cargo)

nicolasbadano · 2016-07-11T18:46:10Z

I like the idea. Let me know if you need assistance.

BaerMitUmlaut · 2016-07-11T18:48:41Z

Can you make sure that when you get in on the left side of a Little Bird for example, you land on the left bench and not on the right one?

jameslkingsley · 2016-07-11T18:54:01Z

I'm not sure how to go about doing that. The move-in stuff is still quite messy - I didn't want to have it just pop you in instantly, but the GetInXXX stuff doesn't seem to work.

jonpas · 2016-07-11T19:13:22Z

I feel like this could be something for ACE3 itself.

nicolasbadano · 2016-07-11T19:39:05Z

Can you make sure that when you get in on the left side of a Little Bird for example, you land on the left bench and not on the right one?

@BaerMitUmlaut, I think that's currently not possible to do (at least reliably). I remember @PabstMirror saying something about not all vehicle positions having proper selections or something like that. Is that right Pabst?

PabstMirror · 2016-07-11T20:09:30Z

It's really not a simple problem to fix.

See acemod/ACE3#273
The getIn memoryPpoints can be an array and we can't seem to access them.

moveInXXX has some problems, it's going to ignore locked vehicles and I think it doesn't trigger the getIn event. But it also allows mixed teams to enter the same vic (loading civilians into a vehicle can be a real pain)

I think doing player action ["getInX", vic] should be safer.

We probably want an ace_setting to enable/disable, and possibly another setting to allow mixed teams to enter the same vic?

nicolasbadano · 2016-07-11T22:30:40Z

addons/quickmount/functions/fnc_getInNearest.sqf

+reverse _objects;
+private _target = _objects param [0, objNull];
+
+if (!isNull _target && {{_target isKindOf _x} count ["Air","LandVehicle","Ship"] > 0}) then {


1- Should you check if the _target is alive too?

2- I think you should add StaticMortar to the list too

nicolasbadano · 2016-07-11T22:43:47Z

addons/quickmount/ACE_Settings.hpp

+        displayName = ACECSTRING(common,Enabled);
+        description = CSTRING(KeybindDescription);
+        isClientSettable = 0;
+        force = 1;


Don't force it; it will prevent it being settable on the mission level.

…r to list

nicolasbadano · 2016-07-11T22:45:32Z

addons/quickmount/ACE_Settings.hpp

+        description = CSTRING(KeybindDescription);
+        isClientSettable = 0;
+        force = 1;
+        values[] = {"0m", "1m", "2m", "3m", "4m", "5m", "6m", "7m", "8m", "9m", "10m"};


This line should be removed.

jameslkingsley · 2016-07-31T22:27:38Z

Is there any interest in having a double-tap the quick-mount key to eject?

jonpas · 2016-08-01T07:04:19Z

Isn't eject already bindable loke that in vanilla controls?

jameslkingsley · 2016-08-01T12:56:48Z

Oh yeah, forgot about that

thojkooi

Hi @jameslkingsley what is the status on this?

thojkooi · 2016-09-20T21:26:16Z

addons/quickmount/functions/fnc_getInNearest.sqf

+    private _hasAction = false;
+
+    {
+        private _unit = _target call compile format ["assigned%1 _this", _x];


This seems slightly strange. Might there be a better way to do this?

I'm not sure there is, unless it was just hard-coded and repeated.

jameslkingsley · 2016-09-20T21:31:23Z

We've been using this for quite some time now and haven't noticed any issues. If you think it fits ACE itself then I'm happy to port it to that instead.

jonpas · 2016-09-20T21:36:29Z

I would say it fits ACE3 itself.

jameslkingsley · 2016-10-29T19:11:33Z

Should I add a check for the velocity of the target vehicle and limit it to stationary/slow moving vehicles?
Not sure if that's how it works..

jonpas · 2016-10-29T19:12:49Z

That sounds like a good check. No jumping on helicopter flying very slow. 😆

jonpas · 2017-02-21T20:22:16Z

Will be moved to ACE3 as per discussions!

SGTGunner · 2017-02-21T21:28:14Z

What is the criteria that allows a mod/feature move from ACEX to ACE3? thx.

jonpas · 2017-02-21T21:33:47Z

Depends on the scope. ACE3 is generally anything that improves realism or very useful gameplay elements. ACEX is anything else that is still somewhat realistic and improves something. Vaguely said, we don't really have any set-in-stone guidelines for that, we usually decide per case basis.

James Kingsley added 4 commits July 11, 2016 17:23

Add initial files for quick mount

ba80da5

Add debug code

86a5f27

Add distance variable (needs to be changed via ACE settings)

6615ac4

Add vehicle code - still needs moveInX code to be fixed

6a0e966

nicolasbadano added WIP feature request labels Jul 11, 2016

Fix direction command

001263e

James Kingsley added 5 commits July 11, 2016 23:14

Add ACE settings

633faea

Add texts to stringtable

250e632

Exit if not enabled, fix object selection, fix positions

01406c0

Rename function

ee15bd7

Exit if no interface, fix strings

b5f0a23

nicolasbadano reviewed Jul 11, 2016
View reviewed changes

James Kingsley added 2 commits July 11, 2016 23:43

Change to lower-case

dc4cbdf

Remove param

9a87450

nicolasbadano reviewed Jul 11, 2016
View reviewed changes

Remove param, use ACE isPlayer func, check target is alive, add morta…

6fe488d

…r to list

nicolasbadano reviewed Jul 11, 2016
View reviewed changes

Remove forced

bbb2141

thojkooi reviewed Sep 20, 2016

View reviewed changes

jonpas modified the milestones: 3.1.0, 3.2.0 Oct 18, 2016

James Kingsley added 4 commits October 28, 2016 23:10

Fix ACEX tag string

a975194

Add beautified component name

001c315

Make client settable for singleplayer use

0f7da45

Add "locked" message

6369cc2

James Kingsley added 5 commits October 30, 2016 01:41

Fix texts

40ce16d

Add speed option

f5f8008

Add priority setting

cab1f64

Change to <=

b2caa06

Change to not client settable

ff9ff03

jonpas closed this Feb 21, 2017

jonpas added the Next ACE label Feb 21, 2017

jonpas removed this from the 3.2.0 milestone Feb 21, 2017

jonpas unassigned thojkooi and jonpas Feb 21, 2017

PabstMirror mentioned this pull request Feb 21, 2017

Vehicle quick mount acemod/ACE3#4931

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Vehicle quick mount #29

Vehicle quick mount #29

jameslkingsley commented Jul 11, 2016 •

edited

Loading

nicolasbadano commented Jul 11, 2016

BaerMitUmlaut commented Jul 11, 2016

jameslkingsley commented Jul 11, 2016

jonpas commented Jul 11, 2016

nicolasbadano commented Jul 11, 2016 •

edited

Loading

PabstMirror commented Jul 11, 2016

nicolasbadano Jul 11, 2016

nicolasbadano Jul 11, 2016

nicolasbadano Jul 11, 2016

jameslkingsley commented Jul 31, 2016

jonpas commented Aug 1, 2016

jameslkingsley commented Aug 1, 2016

thojkooi left a comment

thojkooi Sep 20, 2016 •

edited

Loading

jameslkingsley Sep 20, 2016

jameslkingsley commented Sep 20, 2016

jonpas commented Sep 20, 2016 •

edited

Loading

jameslkingsley commented Oct 29, 2016 •

edited

Loading

jonpas commented Oct 29, 2016

jonpas commented Feb 21, 2017

SGTGunner commented Feb 21, 2017

jonpas commented Feb 21, 2017 •

edited

Loading

Vehicle quick mount #29

Vehicle quick mount #29

Conversation

jameslkingsley commented Jul 11, 2016 • edited Loading

nicolasbadano commented Jul 11, 2016

BaerMitUmlaut commented Jul 11, 2016

jameslkingsley commented Jul 11, 2016

jonpas commented Jul 11, 2016

nicolasbadano commented Jul 11, 2016 • edited Loading

PabstMirror commented Jul 11, 2016

nicolasbadano Jul 11, 2016

Choose a reason for hiding this comment

nicolasbadano Jul 11, 2016

Choose a reason for hiding this comment

nicolasbadano Jul 11, 2016

Choose a reason for hiding this comment

jameslkingsley commented Jul 31, 2016

jonpas commented Aug 1, 2016

jameslkingsley commented Aug 1, 2016

thojkooi left a comment

Choose a reason for hiding this comment

thojkooi Sep 20, 2016 • edited Loading

Choose a reason for hiding this comment

jameslkingsley Sep 20, 2016

Choose a reason for hiding this comment

jameslkingsley commented Sep 20, 2016

jonpas commented Sep 20, 2016 • edited Loading

jameslkingsley commented Oct 29, 2016 • edited Loading

jonpas commented Oct 29, 2016

jonpas commented Feb 21, 2017

SGTGunner commented Feb 21, 2017

jonpas commented Feb 21, 2017 • edited Loading

jameslkingsley commented Jul 11, 2016 •

edited

Loading

nicolasbadano commented Jul 11, 2016 •

edited

Loading

thojkooi Sep 20, 2016 •

edited

Loading

jonpas commented Sep 20, 2016 •

edited

Loading

jameslkingsley commented Oct 29, 2016 •

edited

Loading

jonpas commented Feb 21, 2017 •

edited

Loading