Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Behavioural Quality Control" and "Imaging Quality Control" modules should have distinct permissions #5718

Closed
johnsaigle opened this issue Nov 21, 2019 · 1 comment · Fixed by #6041
Closed

"Behavioural Quality Control" and "Imaging Quality Control" modules should have distinct permissions #5718

johnsaigle opened this issue Nov 21, 2019 · 1 comment · Fixed by #6041
Labels
Beginner Friendly PR or Issue appears to be easy for someone to use to familiarize themselves with LORIS Category: Feature PR or issue that aims to introduce a new feature Category: Security PR or issue that aims to improve security

Comments

@johnsaigle
Copy link
Contributor

Currently both use a single permission "quality_control". It would be better to have two separate permissions to allow for more granular configuration of a project.

Neither of them appear to have any editing functionality so I think it's safe to have a single "view" permission and no "edit" permission, but let me know if I'm wrong on this point.
@johnsaigle johnsaigle added Category: Feature PR or issue that aims to introduce a new feature Category: Security PR or issue that aims to improve security labels Nov 21, 2019
@racostas
Copy link
Contributor

strongly agree @johnsaigle.

@driusan driusan added the Beginner Friendly PR or Issue appears to be easy for someone to use to familiarize themselves with LORIS label Nov 26, 2019
@johnsaigle johnsaigle mentioned this issue Feb 10, 2020
Merged
driusan pushed a commit that referenced this issue Jul 8, 2020
@johnsaigle
Add module-specific permissions for Survey, Imaging QC, Behavioural QC (
ff2ecc9 
#6041)

    Resolves #5718
    Resolves #5834
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this issue Jun 29, 2021
@johnsaigle @AlexandraLivadas
Add module-specific permissions for Survey, Imaging QC, Behavioural QC (
e4838ba 
aces#6041)

    Resolves aces#5718
    Resolves aces#5834
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Beginner Friendly PR or Issue appears to be easy for someone to use to familiarize themselves with LORIS Category: Feature PR or issue that aims to introduce a new feature Category: Security PR or issue that aims to improve security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add module-specific permissions for Survey, Imaging QC, Behavioural QC
3 participants
@driusan @johnsaigle @racostas