Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module-specific permissions for Survey, Imaging QC, Behavioural QC #6041

Merged
merged 18 commits into from
Jul 8, 2020
Merged

Add module-specific permissions for Survey, Imaging QC, Behavioural QC #6041

merged 18 commits into from
Jul 8, 2020

Conversation

johnsaigle
Copy link
Contributor

@johnsaigle johnsaigle added Release: Add to release notes PR whose changes should be highlighted in the release notes Category: Feature PR or issue that aims to introduce a new feature Release: Breaking changes PR that contains changes that might impact the code or accepted practices of active projects Category: Documentation PR or issue that aims to improve the documentation (test plans, wiki, comments...) Category: Security PR or issue that aims to improve security Language: SQL PR or issue that update SQL code State: Needs RB update PR that needs to update Raisinbread to reflect its changes labels Feb 10, 2020
PapillonMcGill
PapillonMcGill previously requested changes Feb 17, 2020
View reviewed changes
modules/behavioural_qc/ajax/GetCandidates.php Outdated Show resolved Hide resolved
modules/behavioural_qc/ajax/GetInstruments.php Outdated Show resolved Hide resolved
modules/behavioural_qc/test/behavioural_qcTest.php Outdated Show resolved Hide resolved
@PapillonMcGill PapillonMcGill added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Feb 17, 2020
@johnsaigle johnsaigle removed State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) State: Needs RB update PR that needs to update Raisinbread to reflect its changes labels Feb 17, 2020
PapillonMcGill
PapillonMcGill previously requested changes Feb 24, 2020
View reviewed changes
modules/imaging_qc/README.md Outdated Show resolved Hide resolved
modules/imaging_qc/README.md Outdated Show resolved Hide resolved
modules/imaging_qc/README.md Outdated Show resolved Hide resolved
@johnsaigle johnsaigle added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Feb 24, 2020
@johnsaigle johnsaigle removed the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Feb 24, 2020
@johnsaigle johnsaigle dismissed PapillonMcGill’s stale review February 24, 2020 20:47

Changes incorporated

@johnsaigle johnsaigle mentioned this pull request Feb 25, 2020
Merged
PapillonMcGill
PapillonMcGill approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@PapillonMcGill PapillonMcGill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still have an extra space but not critical as not displayed.

modules/imaging_qc/README.md Show resolved Hide resolved
driusan
driusan requested changes Mar 5, 2020
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
PapillonMcGill
PapillonMcGill reviewed Mar 9, 2020
View reviewed changes
CHANGELOG.md Outdated
@@ -16,6 +16,10 @@ changes in the following format: PR #1234***
- Very old instruments relying on QuickForm may have issues due to code changes (PR #4928)
- Unix user permissions have been updated which may affect access to files. New
documentation for file permissions has been added to the README.md file (PR #5323)
- Very old instrument relying on QuickForm may have issues due to code changes (PR #4928)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a blocker but would be great if all lines end with dots.

@johnsaigle johnsaigle added State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) and removed State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) labels Jun 15, 2020
@johnsaigle
Copy link
Contributor Author

@driusan Can you review?

@johnsaigle johnsaigle requested a review from driusan June 16, 2020 14:29
@driusan driusan added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Jun 19, 2020
@ridz1208
Copy link
Collaborator

@johnsaigle to rebase

@johnsaigle johnsaigle removed the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Jun 29, 2020
johnsaigle and others added 13 commits July 8, 2020 09:54
@johnsaigle @PapillonMcGill
Apply suggestions from code review
05e4c4e 
Co-Authored-By: PapillonMcGill <34311645+PapillonMcGill@users.noreply.github.com>
@johnsaigle
Add RB permissions
8c112fb
@johnsaigle @PapillonMcGill
Apply suggestions from code review
d677224 
Co-Authored-By: PapillonMcGill <34311645+PapillonMcGill@users.noreply.github.com>
@johnsaigle
Fix bullet points
4935fcb
@johnsaigle
Rebase changes
0a65645
@johnsaigle
make wording consistent and fix typo
bed9154
@johnsaigle
phpcs
d03d05e
@johnsaigle @driusan
Update CHANGELOG.md
9337a92 
Co-authored-by: Dave MacFarlane <driusan@gmail.com>
@johnsaigle
phpcs
c6f09f4
@johnsaigle
new tool for permissions
73cc8f1
@johnsaigle
Fix query issue
054be4a
@johnsaigle
Modify patch
49c45c9
@johnsaigle
remove php script
6049b58
@johnsaigle johnsaigle requested a review from driusan July 8, 2020 14:01
@johnsaigle johnsaigle removed the Release: Breaking changes PR that contains changes that might impact the code or accepted practices of active projects label Jul 8, 2020
@johnsaigle johnsaigle added "Help! I don't understand Travis!" PR is having a beef with TRAVIS. Someone needs to help and removed "Help! I don't understand Travis!" PR is having a beef with TRAVIS. Someone needs to help labels Jul 8, 2020
@driusan driusan merged commit ff2ecc9 into aces:master Jul 8, 2020
@ridz1208 ridz1208 added this to the 24.0.0 milestone Jul 15, 2020
driusan pushed a commit that referenced this pull request Aug 12, 2020
@johnsaigle
[Imaging QC + Behavioural QC] Cleanup integration test code (#6103)
1c97e95 
Use changes PRs #5619, #6041, and #6046 to simplify the integration tests for Imaging QC and behavioural QC modules.
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this pull request Jun 15, 2021
@johnsaigle @AlexandraLivadas
[Imaging QC + Behavioural QC] Cleanup integration test code (aces#6103)
67532bd 
Use changes PRs aces#5619, aces#6041, and aces#6046 to simplify the integration tests for Imaging QC and behavioural QC modules.
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this pull request Jun 29, 2021
@johnsaigle @AlexandraLivadas
Add module-specific permissions for Survey, Imaging QC, Behavioural QC (
e4838ba 
aces#6041)

    Resolves aces#5718
    Resolves aces#5834
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this pull request Jun 29, 2021
@johnsaigle @AlexandraLivadas
[Imaging QC + Behavioural QC] Cleanup integration test code (aces#6103)
2587131 
Use changes PRs aces#5619, aces#6041, and aces#6046 to simplify the integration tests for Imaging QC and behavioural QC modules.
@zaliqarosli zaliqarosli mentioned this pull request Jun 19, 2023
Closed
@ridz1208 ridz1208 mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PapillonMcGill PapillonMcGill PapillonMcGill approved these changes

@driusan driusan driusan approved these changes

Assignees

@driusan driusan

Labels
Category: Documentation PR or issue that aims to improve the documentation (test plans, wiki, comments...) Category: Feature PR or issue that aims to introduce a new feature Category: Security PR or issue that aims to improve security Language: SQL PR or issue that update SQL code Release: Add to release notes PR whose changes should be highlighted in the release notes
Projects
None yet
Milestone
24.0.0
4 participants
@johnsaigle @ridz1208 @driusan @PapillonMcGill