Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[candidate_parameters] Test plan and README do not describe widgets #6433

Closed
driusan opened this issue Apr 27, 2020 · 0 comments · Fixed by #6456
Closed

[candidate_parameters] Test plan and README do not describe widgets #6433

driusan opened this issue Apr 27, 2020 · 0 comments · Fixed by #6456
Assignees
@driusan
Labels
Category: Bug PR or issue that aims to report or fix a bug Category: Documentation PR or issue that aims to improve the documentation (test plans, wiki, comments...) Meta PR does something that organizes, upgrades, or manages the functionality of the codebase

Comments

@driusan
Copy link
Collaborator

driusan commented Apr 27, 2020

The test plan for the candidate_parameters module registers widgets into the candidate_profile, but the README does not describe the interaction and the test plan does not test the widget.
@driusan driusan added Category: Bug PR or issue that aims to report or fix a bug 23.0.0-testing Category: Documentation PR or issue that aims to improve the documentation (test plans, wiki, comments...) Meta PR does something that organizes, upgrades, or manages the functionality of the codebase labels Apr 27, 2020
This was referenced Apr 27, 2020
Merged
Closed
driusan added a commit to driusan/Loris that referenced this issue Apr 29, 2020
@driusan
[candidate_parameters] Update test plan and README to include widgets
718f38f 
Update the test plan to include the widgets registered in other modules.

Fixes aces#6433
driusan added a commit to driusan/Loris that referenced this issue Apr 29, 2020
@driusan
[candidate_parameters] Update test plan and README to include widgets
7b9a877 
Update the test plan to include the widgets registered in other modules.

Fixes aces#6433
@driusan driusan mentioned this issue Apr 29, 2020
Merged
driusan added a commit that referenced this issue May 6, 2020
@driusan
[candidate_parameters] Update test plan and README to include widgets (…
5bcb86c 
…#6456)

Update the test plan to include the widgets registered in other modules.

Fixes #6433
HenriRabalais pushed a commit to HenriRabalais/Loris that referenced this issue May 27, 2020
@driusan @HenriRabalais
[candidate_parameters] Update test plan and README to include widgets (…
08e5173 
…aces#6456)

Update the test plan to include the widgets registered in other modules.

Fixes aces#6433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@driusan driusan

Labels
Category: Bug PR or issue that aims to report or fix a bug Category: Documentation PR or issue that aims to improve the documentation (test plans, wiki, comments...) Meta PR does something that organizes, upgrades, or manages the functionality of the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[candidate_parameters] Update test plan and README to include widgets driusan/Loris
1 participant
@driusan