[candidate_parameters] Update test plan and README to include widgets #6456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the test plan to include the widgets registered in other modules. Fixes aces#6433
driusan
added
Category: Documentation
christinerogers
previously requested changes
May 1, 2020
| 41. Access a candidate in the `candidate_profile` module | ||
|
|
||
| ### Candidate Info Widget terms | ||
| 42. Within the "Candidate Info" card, after the information which |
There was a problem hiding this comment.
point 42 : How is the user to test this?
If it's not testable, it's just pre-amble for what follows, and shouldn't get a number.
Co-authored-by: christinerogers <christinerogers@users.noreply.github.com>
There was a problem hiding this comment.
Hi @driusan -- Could you clarify about point 42 from my previous comment?
Not sure if you saw that before requesting my re-review. Otherwise looks good to go.
driusan
force-pushed
the
CandidateParametersTP
branch
from
9d99b6d to
083d221
Compare
HenriRabalais
pushed a commit
to HenriRabalais/Loris
that referenced
this pull request
May 27, 2020
…aces#6456) Update the test plan to include the widgets registered in other modules. Fixes aces#6433
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the test plan to include the widgets registered in other modules.
Fixes #6433