Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[conflict_resolver] README and test plan do not describe/test widgets #6434

Closed
driusan opened this issue Apr 27, 2020 · 0 comments · Fixed by #6454
Closed

[conflict_resolver] README and test plan do not describe/test widgets #6434

driusan opened this issue Apr 27, 2020 · 0 comments · Fixed by #6454
Assignees
@driusan
Labels
Category: Bug PR or issue that aims to report or fix a bug Category: Documentation PR or issue that aims to improve the documentation (test plans, wiki, comments...) Meta PR does something that organizes, upgrades, or manages the functionality of the codebase

Comments

@driusan
Copy link
Collaborator

driusan commented Apr 27, 2020

The README for the conflict resolver does not describe the fact that it registers widgets on the dashboard or the candidate_profile dashboard, and the test plan does not describe how to test them.
@driusan driusan added Category: Bug PR or issue that aims to report or fix a bug Category: Documentation PR or issue that aims to improve the documentation (test plans, wiki, comments...) Meta PR does something that organizes, upgrades, or manages the functionality of the codebase 23.0.0-testing labels Apr 27, 2020
This was referenced Apr 27, 2020
Merged
Closed
driusan added a commit to driusan/Loris that referenced this issue Apr 28, 2020
@driusan
[conflict_resolver] Update test plan and README to test widgets
bf1ed49 
Fixes aces#6434
@driusan driusan mentioned this issue Apr 28, 2020
Merged
@ridz1208 ridz1208 mentioned this issue May 6, 2020
Closed
driusan added a commit that referenced this issue May 13, 2020
@driusan
[conflict_resolver] Update test plan and README to test widgets (#6454)
b21c58a 
Update conflict resolver to include tests for the widgets it includes in different modules.

Fixes #6434.
HenriRabalais pushed a commit to HenriRabalais/Loris that referenced this issue May 27, 2020
@driusan @HenriRabalais
[conflict_resolver] Update test plan and README to test widgets (aces…
aca9b76 
…#6454)

Update conflict resolver to include tests for the widgets it includes in different modules.

Fixes aces#6434.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@driusan driusan

Labels
Category: Bug PR or issue that aims to report or fix a bug Category: Documentation PR or issue that aims to improve the documentation (test plans, wiki, comments...) Meta PR does something that organizes, upgrades, or manages the functionality of the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[conflict_resolver] Update test plan and README to test widgets driusan/Loris
1 participant
@driusan