[conflict_resolver] Update test plan and README to test widgets #6454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driusan
added
the
Category: Documentation
christinerogers
requested changes
May 1, 2020
PapillonMcGill
suggested changes
May 4, 2020
Co-authored-by: christinerogers <christinerogers@users.noreply.github.com>
Co-authored-by: PapillonMcGill <34311645+PapillonMcGill@users.noreply.github.com>
Co-authored-by: christinerogers <christinerogers@users.noreply.github.com>
Co-authored-by: christinerogers <christinerogers@users.noreply.github.com>
PapillonMcGill
approved these changes
May 6, 2020
ridz1208
reviewed
May 8, 2020
| @@ -66,3 +66,6 @@ If the `conflicts_unresolved` table somehow becomes out of sync | |||
| with the data in LORIS, the `tools/recreate_conflicts.php` script | |||
| can be used to re-compare single and double data entry values | |||
| and repopulate the `conflicts_unresolved` table. | |||
|
|
|||
| The conflict resolver registers modules on the dashboard and the | |||
| `candidate_profile` dashboard. | |||
There was a problem hiding this comment.
Suggested change
| `candidate_profile` dashboard. | |
| `candidate_profile` modules. |
I don't like calling it a dashboard to avoid confusion with THE dashboard which is a module
There was a problem hiding this comment.
It's emphatically designed to be a dashboard.
Co-authored-by: Rida Abou-Haidar <ridz1208@users.noreply.github.com>
ridz1208
approved these changes
May 12, 2020
christinerogers
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update conflict resolver to include tests for the widgets it includes in different modules.
Fixes #6434.