[MRI Violations] violated_scans_edit permission should be removed

[driusan]

The default schema includes the permission:

(20,'violated_scans_edit','Violated Scans: Edit MRI protocol table','2'),

This appears to have only one reference in resolved_violations.class.inc

        $this->tpl_data['violated_scans_modifications']
            = $user->hasPermission('violated_scans_edit');

However, the violated_scans_modifications template variable is not referenced in any template. The code and permission can be removed.

[christinerogers]

this is a followup cleanup task from making the mri_protocol table read-only in #6372

[mohadesz]

I kind of liked the editing option for MRI_protocol table via front-end

…

On Tue, Oct 6, 2020 at 10:43 AM christinerogers ***@***.***> wrote: this is a followup cleanup task from making the mri_protocol table read-only in #6372 <#6372> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#6723 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAD4FEK3Y44O2S74OJYJWKTSJMUJ5ANCNFSM4N3VSIWA> .

[christinerogers]

our condolences @mohadesz :)