Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SQL Cleanup Patch] Remove violated_scans_edit permission #6747

Merged
merged 2 commits into from
Dec 7, 2020
Merged

[SQL Cleanup Patch] Remove violated_scans_edit permission #6747

merged 2 commits into from
Dec 7, 2020

Conversation

laemtl
Copy link
Contributor

@laemtl laemtl commented Jun 18, 2020

A patch was created to Remove the unused permission violated_scans_edit from the database.

@laemtl laemtl requested a review from christinerogers June 18, 2020 20:15
driusan
driusan requested changes Jun 19, 2020
View reviewed changes
Copy link
Collaborator

@driusan driusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the change to SQL/0000-00-01-Permission.sql

@laemtl laemtl force-pushed the 2020-06-18-remove-perm-violated_scans_modifications branch from 7f459b5 to 3940572 Compare June 19, 2020 15:56
@laemtl laemtl requested a review from driusan June 19, 2020 15:56
@laemtl laemtl added the Cleanup PR or issue introducing/requiring at least one clean-up operation label Jun 29, 2020
@laemtl
Copy link
Contributor Author

laemtl commented Jul 8, 2020

@driusan Ready for review.

@laemtl laemtl changed the base branch from master to main July 21, 2020 15:43
ridz1208
ridz1208 requested changes Aug 12, 2020
View reviewed changes
Copy link
Collaborator

@ridz1208 ridz1208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please run this patch on the RB dataset and submit the changes

@laemtl laemtl added the State: Needs work PR awaiting additional work by the author to proceed label Aug 19, 2020
@laemtl
Copy link
Contributor Author

laemtl commented Aug 24, 2020

@ridz1208 Done!

@laemtl laemtl removed the State: Needs work PR awaiting additional work by the author to proceed label Aug 24, 2020
@laemtl laemtl requested a review from ridz1208 August 24, 2020 17:05
@laemtl
Copy link
Contributor Author

laemtl commented Nov 23, 2020

@driusan Ready for review

@driusan driusan merged commit 2d16ce0 into aces:main Dec 7, 2020
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this pull request Jun 29, 2021
@laemtl @AlexandraLivadas
[SQL Cleanup Patch] Remove violated_scans_edit permission (aces#6747)
91d5d9e 
A patch was created to Remove the unused permission violated_scans_edit from the database.

    Resolves aces#6723
@ridz1208 ridz1208 added this to the 24.0.0 milestone Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ridz1208 ridz1208 ridz1208 approved these changes

@christinerogers christinerogers Awaiting requested review from christinerogers

@driusan driusan Awaiting requested review from driusan

Assignees
No one assigned
Labels
Cleanup PR or issue introducing/requiring at least one clean-up operation
Projects
None yet
Milestone
24.0.0
Development

Successfully merging this pull request may close these issues.

[MRI Violations] violated_scans_edit permission should be removed
3 participants
@laemtl @driusan @ridz1208