Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[imaging_uploader] Upload does not start when overwriting existing file #6978

Closed
jesscall opened this issue Sep 4, 2020 · 0 comments · Fixed by #7084
Closed

[imaging_uploader] Upload does not start when overwriting existing file #6978

jesscall opened this issue Sep 4, 2020 · 0 comments · Fixed by #7084
Assignees
@nicolasbrossard
Labels
Category: Bug PR or issue that aims to report or fix a bug
Milestone
24.0.0

Comments

@jesscall
Copy link
Contributor

jesscall commented Sep 4, 2020

Describe the bug
Step 9 of test plan:

Upload a scan which was already uploaded and which has either 'Not Started' or 'Failure' status in the Progress column. Ensure you get the Warning message 'Are you sure? A file with this name already exists! Would you like to override existing file?'. Ensure the correct behaviour of the two possible actions by the user: 'Yes, I am sure!' or 'No, cancel it!'.
[Manual Testing]

When selecting 'Yes' to overwrite the file, the upload does not begin. Console error shows callback is not set.

To Reproduce
Steps to reproduce the behavior (attach screenshots if applicable):

  1. Upload a file that already exists.
  2. Select 'Yes' when presented with this message:

Screen Shot 2020-09-04 at 11 22 18 AM

  1. Observe that upload does not begin.

What did you expect to happen?
For the upload to occur.
@jesscall jesscall added the Category: Bug PR or issue that aims to report or fix a bug label Sep 4, 2020
@jesscall jesscall added this to the 24.0.0 milestone Sep 4, 2020
@nicolasbrossard nicolasbrossard mentioned this issue Oct 6, 2020
Merged
driusan pushed a commit that referenced this issue Oct 13, 2020
@nicolasbrossard
[imaging_uploader] Fixed imaging uploader that would not automaticall…
8e05378 
…y start when overwriting a file. (#7084)

This PR fixes a bug that would prevent the imaging uploader from starting automatically even if you had the imaging uploader auto-launch set to true and your current upload overwrote an existing file.

It replaces the swal1 style callback function invocations to swal2 style JS promises.

    Resolves #6978
spell00 pushed a commit to spell00/Loris that referenced this issue Nov 4, 2020
@nicolasbrossard @spell00
[imaging_uploader] Fixed imaging uploader that would not automaticall…
e429bdb 
…y start when overwriting a file. (aces#7084)

This PR fixes a bug that would prevent the imaging uploader from starting automatically even if you had the imaging uploader auto-launch set to true and your current upload overwrote an existing file.

It replaces the swal1 style callback function invocations to swal2 style JS promises.

    Resolves aces#6978
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this issue Jun 29, 2021
@nicolasbrossard @AlexandraLivadas
[imaging_uploader] Fixed imaging uploader that would not automaticall…
ba49a46 
…y start when overwriting a file. (aces#7084)

This PR fixes a bug that would prevent the imaging uploader from starting automatically even if you had the imaging uploader auto-launch set to true and your current upload overwrote an existing file.

It replaces the swal1 style callback function invocations to swal2 style JS promises.

    Resolves aces#6978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolasbrossard nicolasbrossard

Labels
Category: Bug PR or issue that aims to report or fix a bug
Projects
None yet
Milestone
24.0.0
2 participants
@nicolasbrossard @jesscall