Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed imaging uploader that would not automatically start when overwriting a file #7084

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

nicolasbrossard
Copy link
Contributor

@nicolasbrossard nicolasbrossard commented Oct 6, 2020

Brief summary of changes

This PR fixes a bug that would prevent the imaging uploader from starting automatically even if you had the imaging uploader auto-launch set to true and your current upload overwrote an existing file. In a nutshell, the PR replaces the swal.fire invocations of this form:

swal.fire({
.
.
}, function () {
.
.
}.bind(this));

with invocations like these:

swal.fire({
.
.
}).then(
.
.
);

Testing instructions (if applicable)

  1. Make sure config setting imaging uploader auto-launch is set to Yes.
  2. Access the imaging uploader and search for a file that was not processed successfully by the MRI pipeline (i.e Progress=Failure).
  3. Upload a file with exactly the same base name as the file you found in 2. When asked if you want to overwrite the file, click Yes.

You should see a message indicating that the MRI pipeline was automatically launched and that your scan archive is being processed. You can also try overwriting a file that has been uploaded but has not yet been processed by the MRI pipeline (Progress=Not Started).

Link(s) to related issue(s)

@jesscall jesscall added the Passed manual tests PR has been successfully tested by at least one peer label Oct 9, 2020
@jesscall
Copy link
Contributor

jesscall commented Oct 9, 2020

looks good!

@driusan driusan merged commit 8e05378 into aces:main Oct 13, 2020
spell00 pushed a commit to spell00/Loris that referenced this pull request Nov 4, 2020
…y start when overwriting a file. (aces#7084)

This PR fixes a bug that would prevent the imaging uploader from starting automatically even if you had the imaging uploader auto-launch set to true and your current upload overwrote an existing file.

It replaces the swal1 style callback function invocations to swal2 style JS promises.

    Resolves aces#6978
@ridz1208 ridz1208 added this to the 24.0.0 milestone Nov 27, 2020
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this pull request Jun 29, 2021
…y start when overwriting a file. (aces#7084)

This PR fixes a bug that would prevent the imaging uploader from starting automatically even if you had the imaging uploader auto-launch set to true and your current upload overwrote an existing file.

It replaces the swal1 style callback function invocations to swal2 style JS promises.

    Resolves aces#6978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed manual tests PR has been successfully tested by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[imaging_uploader] Upload does not start when overwriting existing file
4 participants