Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[publication] Unable to download uploaded files #9133

Closed
jeffersoncasimir opened this issue Mar 14, 2024 · 2 comments · Fixed by #9208
Closed

[publication] Unable to download uploaded files #9133

jeffersoncasimir opened this issue Mar 14, 2024 · 2 comments · Fixed by #9208
Assignees
@jeffersoncasimir
Labels
26.0.0-bugs Issues that were raised during the release testing for 26.0.0 Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)

Comments

@jeffersoncasimir
Copy link
Contributor

jeffersoncasimir commented Mar 14, 2024 •
edited
Loading

As stated in the TestPlan.md: You should be able to view a static version of the project proposal and be able to download the uploaded files.

I am unable to download the files currently associated with any project with uploaded files.

Examples:
https://test-dev-260.loris.ca/publication/view_project?id=2
https://test-dev-260.loris.ca/publication/view_project?id=4
@jeffersoncasimir jeffersoncasimir added Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) 26.0.0-bugs Issues that were raised during the release testing for 26.0.0 labels Mar 14, 2024
@driusan
Copy link
Collaborator

driusan commented Apr 2, 2024

Are these things you uploaded or things that were already there? It's possible the files aren't there on the test VM if it was just loaded from an RB dump.

@jeffersoncasimir
Copy link
Contributor Author

I uploaded files and couldn't download them. I just double-checked now and it is still the case.

@jeffersoncasimir jeffersoncasimir mentioned this issue Apr 4, 2024
Closed
@jeffersoncasimir jeffersoncasimir mentioned this issue Apr 16, 2024
Merged
driusan pushed a commit that referenced this issue Apr 16, 2024
@jeffersoncasimir
[publication] Fix download prevention by overriding download notifica…
f111b9c 
…tion function (#9208)

An error regarding the non-existence of a notification_module with module: publication and operation: download prevented the downloading of files.

The notification function was overridden for this module to bypass the LorisException thrown by the non-existence of entries. It appeared by far to be a simpler solution than checking for and adding extra logic when the entries do not exist.

Resolves  #9133.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffersoncasimir jeffersoncasimir

Labels
26.0.0-bugs Issues that were raised during the release testing for 26.0.0 Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Milestone
No milestone
3 participants
@driusan @jeffersoncasimir @CamilleBeau