Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[publication] Fix download prevention by adding download notification #9193

Closed
wants to merge 4 commits into from
Closed

[publication] Fix download prevention by adding download notification #9193

wants to merge 4 commits into from

Conversation

jeffersoncasimir
Copy link
Contributor

@jeffersoncasimir jeffersoncasimir commented Apr 4, 2024 •
edited
Loading

Closes #9133.

An error regarding the non-existence of a notification_module with module: publication and operation: download prevented the downloading of files.

TODO: Add patch to RB inserts if solution is approved

Before testing

  • Run the SQL patch
  • Check the new checkbox in your preferences to enable receiving the e-mail

Testing

  • Successfully download an uploaded file in the publication module
  • Confirm the reception of a notification e-mail and that the placeholders are correctly replaced

@jeffersoncasimir jeffersoncasimir added the 26.0.0-bugs Issues that were raised during the release testing for 26.0.0 label Apr 4, 2024
@jeffersoncasimir jeffersoncasimir changed the title [publication] Fix download prevention error by adding publication download notification [publication] Fix download prevention error by adding download notification Apr 4, 2024
@jeffersoncasimir jeffersoncasimir changed the title [publication] Fix download prevention error by adding download notification [publication] Fix download prevention by adding download notification Apr 4, 2024
@maximemulder maximemulder self-assigned this Apr 11, 2024
maximemulder
maximemulder approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@maximemulder maximemulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my VM, this PR seems to work fine !

@maximemulder maximemulder mentioned this pull request Apr 11, 2024
Closed
@maximemulder maximemulder added the Passed Manual Tests PR has undergone proper testing by at least one peer label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximemulder maximemulder maximemulder approved these changes

Assignees

@maximemulder maximemulder

Labels
26.0.0-bugs Issues that were raised during the release testing for 26.0.0 Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[publication] Unable to download uploaded files
2 participants
@jeffersoncasimir @maximemulder