[MRI Violated scans] Have the minc file linked to brainbrowser (Redmine 10928) #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gluneau
added
the
Category: Feature
Current coverage is 13.80% (diff: 0.00%)@@ 17.0-dev #2219 diff @@
==========================================
Files 121 121
Lines 20191 20196 +5
Methods 1133 1133
Messages 0 0
Branches 0 0
==========================================
+ Hits 2787 2788 +1
- Misses 17404 17408 +4
Partials 0 0
|
gluneau
added
the
Passed manual tests
|
Tested on IBIS production |
driusan
requested changes
Oct 3, 2016
| @@ -171,6 +174,7 @@ class NDB_Menu_Filter_Form_mri_violations extends NDB_Menu_Filter_Form | |||
| c.ProjectID as Project, | |||
| s.SubprojectID as Subproject, | |||
| minc_location as MincFile, | |||
| CONCAT_WS('','" . $dir_path . "','trashbin/',SUBSTRING_INDEX(minc_location, '/', -2)) as MincFileViolated, | |||
There was a problem hiding this comment.
this should use the $DB->quote function
| @@ -195,6 +199,7 @@ class NDB_Menu_Filter_Form_mri_violations extends NDB_Menu_Filter_Form | |||
| c.ProjectID as Project, | |||
| s.SubprojectID as Subproject, | |||
| MincFile, | |||
| IF(INSTR(`MincFile`, 'assembly'), IF(LEFT(`MincFile`, 8) = 'assembly',CONCAT_WS('','" . $dir_path . "',`MincFile`),`MincFile`), CONCAT_WS('','" . $dir_path . "','trashbin/',SUBSTRING_INDEX(MincFile, '/', -2))) as MincFileViolated, | |||
There was a problem hiding this comment.
This line seems really complex and hard to understand. Does whatever it's doing need to be in SQL or can it be done in code?
Either way, it should at least have a comment explaining it. (dir_path should also be quoted using the db quote function)
driusan
added
Release: Add to release notes
remove extra lines
driusan
approved these changes
Oct 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MRI Violated Scans now has a new column named MincFileViolated with a link that opens the scan in Brain Browser even if it is in the trashbin directory.