Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[MRI Violated scans] Have the minc file linked to brainbrower (Redmine 10928) (#2219)" #2794

Merged
merged 1 commit into from
May 10, 2017

Conversation

driusan
Copy link
Collaborator

@driusan driusan commented May 10, 2017

This reverts commit 1bf483f.

The addition of the parameter "minc_location" parameter added by this commit introduces
a severe security hole, where user input is getting passed directly to the PHP
passthru command.

…r (Redmine 10928) (aces#2219)"

This reverts commit 1bf483f.

The addition of the parameter "minc_location" parameter added by this commit introduces
a severe security hole, where user input is getting passed directly to the PHP
passthru command.
@driusan driusan added the Category: Bug PR or issue that aims to report or fix a bug label May 10, 2017
@driusan driusan added this to the 17.0 milestone May 10, 2017
@driusan driusan requested review from prioux and gluneau May 10, 2017 19:23
@prioux
Copy link
Member

prioux commented May 10, 2017

The fix to minc.php seems good to me.

@driusan driusan merged commit a565e76 into aces:17.0-dev May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug PR or issue that aims to report or fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants