Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool cleanup_mri_tables_for_19-0_release.php prompting for MySQL username and password #3473

Conversation

cmadjar
Copy link
Collaborator

@cmadjar cmadjar commented Feb 5, 2018

This pull request modifies the way the mysqldump is called in cleanup_mri_tables_for_19-0_release.php.

Instead of using the username and password from the config.xml file, it will prompt the user running the script to enter the MySQL username and password to use for mysqldump.

@cmadjar cmadjar added Language: SQL PR or issue that update SQL code Critical to release PR or issue is key for the release to which it has been assigned [branch] major labels Feb 5, 2018
@cmadjar cmadjar added this to the 19.0 milestone Feb 5, 2018
@cmadjar cmadjar requested a review from driusan February 5, 2018 22:26
@ridz1208 ridz1208 added Passed manual tests PR has been successfully tested by at least one peer and removed [branch] major labels Feb 6, 2018
@ridz1208
Copy link
Collaborator

ridz1208 commented Feb 7, 2018

it works!! but i'm having a separate issue now.

The script outputs the file in the directory where its being run from
it should instead add the file to a specific directory such as project/backup/ which would be created if it does not exist

should be a separate PR

@driusan driusan merged commit d884357 into aces:19.0-dev Feb 7, 2018
driusan pushed a commit that referenced this pull request Feb 19, 2018
…ject/backup now (#3483)

This updates the cleanup_mri_tables_for_19-0_release.php script to save the backup SQL file in project/backup as suggested in PR #3473 by @ridz1208.
@cmadjar cmadjar deleted the PromptingUserPasswordToToolScriptToRunBeforeThePatch branch April 9, 2018 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical to release PR or issue is key for the release to which it has been assigned Language: SQL PR or issue that update SQL code Passed manual tests PR has been successfully tested by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants