Back up SQL from cleanup_mri_tables_for_19-0_release.php saved in project/backup now #3483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmadjar
added
Cleanup
PapillonMcGill
previously approved these changes
Feb 12, 2018
ridz1208
requested changes
Feb 12, 2018
| @@ -263,6 +263,11 @@ function backupEntries($selectID, $table_name, $FK_field) | |||
| $IDs = generateIdList($selectID, $FK_field); | |||
| $where = $FK_field . " IN (" . $IDs . ")"; | |||
|
|
|||
| // create directory where the back up will go if it does not exist yet | |||
| if ( !file_exists("../project/backup") ) { | |||
There was a problem hiding this comment.
these should include the __DIR__ see line 273
otherwise someone running it from another directory than tools would have issues
|
@ridz1208 Oups... Thanks. Should be fixed now. |
ridz1208
previously approved these changes
Feb 12, 2018
|
@cmadjar can you rebase this now that Travis is fixed? |
…om somewhere else can save to the right location
ridz1208
force-pushed
the
WriteSqlInProjectBackupFolder
branch
from
80b0c6d to
eda1f89
Compare
ridz1208
approved these changes
Feb 16, 2018
|
@driusan rebase and tested |
ridz1208
added
the
Passed manual tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows the cleanup_mri_tables_for_19-0_release.php script to save the backup SQL file in project/backup as suggested in PR #3473 by @ridz1208.
Should add in the release that the backup SQL created by the script will be located in project/backup.
@ridz1208 I put you as a reviewer for this PR. Let me know if that works.