Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dqg cosmetic rebased #4

Merged
merged 16 commits into from
Feb 9, 2012
Merged

Dqg cosmetic rebased #4

merged 16 commits into from
Feb 9, 2012

Conversation

driusan
Copy link
Collaborator

@driusan driusan commented Aug 31, 2011

This branch pulls together a bunch of cosmetic changes to the data query gui, such as the weird scrolling when you have a very large category being inside of a frame instead of going horizontally, and fixes a bug where the ordering of fields wasn't alphabetical.

driusan added 14 commits August 31, 2011 15:13
Javascript was implicitly ordering based on the key when doing a for ... in loop, while
the code was written assuming ordering based on the order inserted. Added a new array
fieldOrderList which stores the order that the ids should be printed in.
This results in useful scrolling in the DQG
Also, explicitly set character encoding to UTF-8 when encoding.

Together, these should fix the display issues that were happening
with descriptions that had special characters in them.
@mohadesz
Copy link
Contributor

Tested and the front end works perfectly fine! However the tools scripts should not be included in this branch and must be fixed.

@driusan
Copy link
Collaborator Author

driusan commented Jan 25, 2012

I think the tools scripts should be removed now.

samirdas added a commit that referenced this pull request Feb 9, 2012
@samirdas samirdas merged commit 7578323 into aces:master Feb 9, 2012
mohadesz pushed a commit that referenced this pull request Apr 17, 2013
Jkat referenced this pull request in Jkat/Loris Oct 21, 2014
Making excel dump more generic
Jkat referenced this pull request in Jkat/Loris Oct 21, 2014
Included the insert_violated_scans function
@driusan driusan added the Area: UI PR or issue related to the user interface label Dec 16, 2014
jstirling91 added a commit that referenced this pull request Nov 19, 2015
stellarxo referenced this pull request in stellarxo/Loris May 9, 2016
Add field for sleep in MRI parameter form
alisterdev added a commit to alisterdev/Loris that referenced this pull request Jul 29, 2016
samirdas pushed a commit that referenced this pull request Aug 2, 2016
alisterdev added a commit to alisterdev/Loris that referenced this pull request Aug 9, 2016
davidblader referenced this pull request in davidblader/Loris Feb 1, 2017
AnyhowStep pushed a commit to AnyhowStep/Loris that referenced this pull request May 25, 2017
…-pass

Attempt to complete refactoring for multi site
llevitis pushed a commit to llevitis/Loris that referenced this pull request Jul 20, 2017
[quality control] merged all relevant changes to imaging + those made to behavioral
@jftunteng jftunteng added this to the PRE 20.0.0 milestone Jan 7, 2020
HenriRabalais referenced this pull request in HenriRabalais/Loris Feb 17, 2020
[Consent] Add CBIGR consent and turn on useConsent
maltheism referenced this pull request in maltheism/Loris May 6, 2020
Adding Etag headers for /candidates/visits/images/Image.php
driusan added a commit that referenced this pull request Oct 29, 2021
When accessing an instrument from RB, I got the error:

```
Fatal error: Uncaught TypeError: Argument 1 passed to ValidatableIdentifier::__construct() must be of the type string, null given, called in
/home/driusan/Code/Loris/php/libraries/NDB_BVL_Instrument.class.inc on line 2863 and defined in /home/driusan/Code/Loris/php/libraries/Valida
tableIdentifier.php:57 Stack trace: #0 /home/driusan/Code/Loris/php/libraries/NDB_BVL_Instrument.class.inc(2863): ValidatableIdentifier->__co
nstruct(NULL) #1 /home/driusan/Code/Loris/src/Middleware/UserPageDecorationMiddleware.php(241): NDB_BVL_Instrument->handle(Object(Laminas\Dia
ctoros\ServerRequest)) #2 /home/driusan/Code/Loris/src/Middleware/PageDecorationMiddleware.php(57): LORIS\Middleware\UserPageDecorationMiddle
ware->process(Object(Laminas\Diactoros\ServerRequest), Object(NDB_BVL_Instrument_aosi)) #3 /home/driusan/Code/Loris/php/libraries/NDB_Page.cl
ass.inc(735): LORIS\Middleware\PageDecorationMiddleware->process(Object(Laminas\Diactoros\ServerRequest), Object(NDB_BVL_Instrument_aosi)) #4
 /home/driusan/Code/Loris/php/libraries/NDB_BVL_In in /home/driusan/Code/Loris/php/libraries/ValidatableIdentifier.php on line 57
```

This fixes the type error so that the instrument page loads.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: UI PR or issue related to the user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants