Untitled #2
Merged
Untitled #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for Candidate_Age and Window_Difference in non-proband instruments
ZainVirani
referenced
this pull request
in ZainVirani/Loris
May 25, 2018
fix candidate issue and transpile
driusan
pushed a commit
that referenced
this pull request
May 28, 2018
* # This is a combination of 3 commits. # This is the 1st commit message: fixing sql injection fixing sql injection Remove debugging line Use ?? idiom replacement # This is the commit message #2: remove variable that was used for debugging # This is the commit message #3: update comment to PHP 7 * remove isset because using ?? idiom * Cleanup variables not used and added logging with error message for user * fix error message to display * fix table name containing back ticks in database * Using DB excape results in back ticks and need to be stripped * remove debugging echo code * function viewData() created and handles showing data with permission check * revert changes to bugfix as was on wrong branch * move function down * travis cleanup * spaces cleanup
1 task
HenriRabalais
referenced
this pull request
in HenriRabalais/Loris
Feb 17, 2020
[Candidate_list] Override
driusan
added a commit
that referenced
this pull request
Oct 29, 2021
When accessing an instrument from RB, I got the error: ``` Fatal error: Uncaught TypeError: Argument 1 passed to ValidatableIdentifier::__construct() must be of the type string, null given, called in /home/driusan/Code/Loris/php/libraries/NDB_BVL_Instrument.class.inc on line 2863 and defined in /home/driusan/Code/Loris/php/libraries/Valida tableIdentifier.php:57 Stack trace: #0 /home/driusan/Code/Loris/php/libraries/NDB_BVL_Instrument.class.inc(2863): ValidatableIdentifier->__co nstruct(NULL) #1 /home/driusan/Code/Loris/src/Middleware/UserPageDecorationMiddleware.php(241): NDB_BVL_Instrument->handle(Object(Laminas\Dia ctoros\ServerRequest)) #2 /home/driusan/Code/Loris/src/Middleware/PageDecorationMiddleware.php(57): LORIS\Middleware\UserPageDecorationMiddle ware->process(Object(Laminas\Diactoros\ServerRequest), Object(NDB_BVL_Instrument_aosi)) #3 /home/driusan/Code/Loris/php/libraries/NDB_Page.cl ass.inc(735): LORIS\Middleware\PageDecorationMiddleware->process(Object(Laminas\Diactoros\ServerRequest), Object(NDB_BVL_Instrument_aosi)) #4 /home/driusan/Code/Loris/php/libraries/NDB_BVL_In in /home/driusan/Code/Loris/php/libraries/ValidatableIdentifier.php on line 57 ``` This fixes the type error so that the instrument page loads.
KLaFleur
pushed a commit
to KLaFleur/Loris
that referenced
this pull request
Sep 20, 2022
Update for new functions
driusan
added a commit
that referenced
this pull request
Jun 21, 2023
The CommentID is not part of the data, it's the foreign key used between the flag table and the instrument table. JSON-based instruments do not have it, and this ensures better consistency between the two so that issues such as #8796 and #8801 will not vary based on instrument type and will be caught sooner. Resolves part of #8804 (Inconsistency #2)
driusan
pushed a commit
that referenced
this pull request
Jan 9, 2025
Fix PHP Fatal error: Uncaught TypeError: substr(): Argument #2 ($offset) must be of type int, false given in /var/www/Loris/php/libraries/NDB_BVL_Instrument_LINST.class.inc:172 from the BMI instrument.
This was referenced Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We haven't had a merge from IBIS to Loris Trunk since the initial move to github, and even then it wasn't complete. I think we to get the Loris Trunk completely up to date now that NeuroDevNet are (very) soon going to start using it.