[Instrument manager] Reactify Menu Filters #4142
Conversation
xlecours
added
Area: UI
| ]; | ||
|
|
||
| const feedback = () => { | ||
| if (!this.state.data.caninstall) { |
There was a problem hiding this comment.
Perhaps canInstall should be passed in a permission object? It just seems to odd to have it as part of 'data'. This may require some restructuring of how we handle permissions on the front end. Is there a way to access this information via this.props.hasPermission?
There was a problem hiding this comment.
I don't think so. Whether or not they can install is a function of the filesystem permissions/setup, not the user's permission.
There was a problem hiding this comment.
I partly agree with you. Yes, it is odd the it is part of the data but it is not a permission either. This tells if quat user is configured correctly so the table can be created.
There was a problem hiding this comment.
@driusan @xlecours Hmm, okay. Yeah, that makes. I guess as we are making standards for the objects we are passing to the front end (e.g. data, fieldOptions, etc.), we may want to group things like this into a configuration object? Rather than have stray configuration booleans in the data object. Not necessary for this PR, just something to think about.
|
|
||
| const uploadTab = () => { | ||
| let content = null; | ||
| if (this.state.data.writable) { |
There was a problem hiding this comment.
Same concern as above.
There was a problem hiding this comment.
Same,this tells if the project/instrument and project/table_sql directory can be written into.
|
@xlecours failing Travis |
|
@driusan Passing now |
Remove the function that counts number of pages. It was used for Pagination of menu filters, which is now done in React. #4142 removes the last usage of it.
Brief summary of changes
Now use react for the menu filter.
Adding filters
Move the upload form in a different table.
Use ajax to upload the instrument.
Adds handler for POST requests in the php file.
This resolves issue...
This module was slowly drifting into the abyss
To test this change...
Please run the test plan.