Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrument manager] Reactify Menu Filters #4142
[Instrument manager] Reactify Menu Filters #4142
Changes from 7 commits
a6326cb
074d3ef
79501e9
ad55ad7
6fb72cf
31c6028
731cbec
d1012e1
b322f1e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps
canInstall
should be passed in a permission object? It just seems to odd to have it as part of 'data'. This may require some restructuring of how we handle permissions on the front end. Is there a way to access this information viathis.props.hasPermission
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. Whether or not they can install is a function of the filesystem permissions/setup, not the user's permission.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I partly agree with you. Yes, it is odd the it is part of the data but it is not a permission either. This tells if quat user is configured correctly so the table can be created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@driusan @xlecours Hmm, okay. Yeah, that makes. I guess as we are making standards for the objects we are passing to the front end (e.g.
data
,fieldOptions
, etc.), we may want to group things like this into aconfiguration
object? Rather than have stray configuration booleans in thedata
object. Not necessary for this PR, just something to think about.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same concern as above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same,this tells if the project/instrument and project/table_sql directory can be written into.