[PHPCS] Make type hinting mandatory

[johnsaigle]

Brief summary of changes

PHPCS now makes type hinting mandatory for function parameters and return types. You can add them automatically based on PHPDocs using phpcbf. mixed annotations don't result in any changes.

Links to related tickets (GitHub, Redmine, ...)

• This is a revamp of [PHPCS] Add type hinting to PHPCS rules #4064

[johnsaigle]

Adding needs work because this is unlikely to pass Travis for another few rounds.

[johnsaigle]

This will be rebased to the "Dev" branch once our new branching system takes effect.

[johnsaigle]

This is now incorporating changes from 22 but there are many phan errors related to this to fix.

[ridz1208]

@johnsaigle wouldn't it be easier to tackle this in smaller chunks ?

[johnsaigle]

@ridz1208 Maybe but not after I've put all this time into it 🤣

And also I have been doing separate PRs for this. There's a whole project about it https://github.com/aces/Loris/projects/11. It would be good to automate this once and for all.

I think PRs adding PHPCS and Phan rules are always pretty big but we can sort it out. We're not releasing anytime soon so even if there are some type errors we can get them fixed.

[ridz1208]

@johnsaigle I'm more concerned about travis

[johnsaigle]

Let me handle Travis 😈