Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[candidate_profile] Add test plan for module #6338

Merged
merged 2 commits into from
Apr 27, 2020
Merged

[candidate_profile] Add test plan for module #6338

merged 2 commits into from
Apr 27, 2020

Conversation

driusan
Copy link
Collaborator

@driusan driusan commented Apr 8, 2020

Add a test plan for new candidate_profile module to test
the functionality provided by the module itself.

Fixes #6207

@driusan
[candidate_profile] Add test plan for module
2bfd76c 
Add a test plan for new `candidate_profile` module to test
the functionality provided by the module itself.
@driusan driusan added Testing PR contains test plan or automated test code (or config files for Travis) Meta PR does something that organizes, upgrades, or manages the functionality of the codebase 23.0.0-testing labels Apr 8, 2020
@driusan driusan mentioned this pull request Apr 8, 2020
Closed
1 task
johnsaigle
johnsaigle suggested changes Apr 8, 2020
View reviewed changes
modules/candidate_profile/test/TestPlan.md
Comment on lines +54 to +55
All other widgets are part of other modules, and should be tested as
part of that module's testing.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
All other widgets are part of other modules, and should be tested as
part of that module's testing.

There are no instructions in the test plans of those modules to do this. So we should either

  • include them here
  • modify this PR to add test instructions in the other test plans
  • create a new 'critical' issue to add these instructions to other test plans.

If you want to take the first approach, I included instructions in #6333 to test the widgets.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then those module test plans should be updated separately, other module's test plans are outside of the scope of this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you open those other PRs then? I figured it would be easier to do here but it's up to you.

The point is that we should have comprehensive testing instructions and so far you haven't done that for this module. As far as I'm concerned this doesn't resolve the the linked issue because even if this PR is merged there are mysteries as to how the total functionality of this module are to be tested.

@johnsaigle johnsaigle added the Critical to release PR or issue is key for the release to which it has been assigned label Apr 8, 2020
@ridz1208 ridz1208 added the Category: Documentation PR or issue that aims to improve the documentation (test plans, wiki, comments...) label Apr 9, 2020
@ridz1208 ridz1208 linked an issue Apr 9, 2020 that may be closed by this pull request
Candidate Profile [Beta] does not have a test plan #6207
Closed
@ridz1208 ridz1208 added this to the 23.0.0 milestone Apr 22, 2020
PapillonMcGill
PapillonMcGill suggested changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@PapillonMcGill PapillonMcGill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, just minor change.

modules/candidate_profile/test/TestPlan.md Outdated Show resolved Hide resolved
modules/candidate_profile/test/TestPlan.md Outdated Show resolved Hide resolved
@driusan @PapillonMcGill
Apply suggestions from code review
b5f1ce9 
Co-Authored-By: PapillonMcGill <34311645+PapillonMcGill@users.noreply.github.com>
@ridz1208
Copy link
Collaborator

@driusan please create issues for each module requiring a testplan update

@driusan
Copy link
Collaborator Author

driusan commented Apr 27, 2020 •
edited
Loading

@ridz #6433, #6434, #6436, #6437, #6438, #6439, #6440, #6441, #6443 .. (a couple of them are about dashboard widgets and not candidate_profile widgets, but I made tickets for everything where the widgets aren't mentioned in the test plan or interactions section of the README.)

@driusan driusan merged commit 93b4f4f into aces:23.0-release Apr 27, 2020
HenriRabalais pushed a commit to HenriRabalais/Loris that referenced this pull request May 27, 2020
@driusan @HenriRabalais
[candidate_profile] Add test plan for module (aces#6338)
9e49e84 
Add a test plan for new `candidate_profile` module to test
the functionality provided by the module itself.

Fixes aces#6207
spell00 pushed a commit to spell00/Loris that referenced this pull request Jun 2, 2020
@driusan @spell00
[candidate_profile] Add test plan for module (aces#6338)
8a037d1 
Add a test plan for new `candidate_profile` module to test
the functionality provided by the module itself.

Fixes aces#6207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsaigle johnsaigle johnsaigle requested changes

@PapillonMcGill PapillonMcGill PapillonMcGill approved these changes

Assignees

@johnsaigle johnsaigle

Labels
Category: Documentation PR or issue that aims to improve the documentation (test plans, wiki, comments...) Critical to release PR or issue is key for the release to which it has been assigned Meta PR does something that organizes, upgrades, or manages the functionality of the codebase Testing PR contains test plan or automated test code (or config files for Travis)
Projects
None yet
Milestone
23.0.0
Development

Successfully merging this pull request may close these issues.

Candidate Profile [Beta] does not have a test plan
4 participants
@driusan @ridz1208 @johnsaigle @PapillonMcGill