-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[User account] Update of the README file and test plan. #6464
[User account] Update of the README file and test plan. #6464
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only thing that maybe should be changed is [Automate Test on Travis_CI] as suggested by @driusan in another PR.
correctly set) when you click on the task. | ||
[Automate Test on Travis_CI] | ||
16. Verify that a user with 'Violated Scans: View all-sites Violated Scans' permission has a task with the number | ||
15. Verify that a user with 'Violated Scans: View all-sites Violated Scans' permission has a task with the number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicolasbrossard What's the larger discussion about moving all of these widget points under their respective modules? (e.g. violated scans). Has there been a decision that all modules should be doing this?
cc @driusan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christinerogers Not sure there was a larger discussion regarding this. Dave requested this change: you might want to check with him.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dashboard test plan was written before the module used any widgets, and no longer houses the code being tested. There are many things you can do now which affect what shows up in the dashboard without the dashboard knowing anything about it.. write a new module for a project which has widgets, disable/enable an existing module in the module manager, override a (non-dashboard) module which is one of the ones that provides widgets.. it's also easier to have someone test the related functionality to a module in the dashboard when testing that module than have someone setup and test (effectively) every module in LORIS at the same time for the "dashboard" test.
The tickets came up when I made tickets for the candidate_profile
widgets that are missing documentation since the dashboard
and candidate_profile
use the same getWidgets()
function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @driusan.
Sounds like the Dashboard Readme needs updating with exactly this info, no?
modules/user_accounts/README.md
Outdated
@@ -51,4 +51,6 @@ additional_user_info | |||
|
|||
- Modifications performed on the MyPreferences page will be reflected on | |||
the user account page when viewing the edited account. | |||
- The user account module registers a widget on the dashboard module to provide | |||
information on the number of accounts that need activation approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
information on the number of accounts that need activation approval. | |
information on the number of accounts that need approval. |
I think this is a typo? I don't know what "activation approval" means..
Update of the user account module's README.md and test plan to cover widget registration on the dashboard page. Resolves aces#6443
Update of the user account module's README.md and test plan to cover widget registration on the dashboard page. Resolves aces#6443
Brief summary of changes
Update of the user account module's
README.md
and test plan to cover widget registration on the dashboard page.Testing instructions (if applicable)
N/A
Link(s) to related issue(s)