Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User account] Update of the README file and test plan. #6464

Merged

Conversation

nicolasbrossard
Copy link
Contributor

Brief summary of changes

Update of the user account module's README.md and test plan to cover widget registration on the dashboard page.

Testing instructions (if applicable)

N/A

Link(s) to related issue(s)

@nicolasbrossard nicolasbrossard added 23.0.0-testing Category: Documentation PR or issue that aims to improve the documentation (test plans, wiki, comments...) Testing PR contains test plan or automated test code (or config files for Travis) labels May 1, 2020
Copy link
Member

@maltheism maltheism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only thing that maybe should be changed is [Automate Test on Travis_CI] as suggested by @driusan in another PR.

correctly set) when you click on the task.
[Automate Test on Travis_CI]
16. Verify that a user with 'Violated Scans: View all-sites Violated Scans' permission has a task with the number
15. Verify that a user with 'Violated Scans: View all-sites Violated Scans' permission has a task with the number
Copy link
Contributor

@christinerogers christinerogers May 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolasbrossard What's the larger discussion about moving all of these widget points under their respective modules? (e.g. violated scans). Has there been a decision that all modules should be doing this?
cc @driusan

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christinerogers Not sure there was a larger discussion regarding this. Dave requested this change: you might want to check with him.

Copy link
Collaborator

@driusan driusan May 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dashboard test plan was written before the module used any widgets, and no longer houses the code being tested. There are many things you can do now which affect what shows up in the dashboard without the dashboard knowing anything about it.. write a new module for a project which has widgets, disable/enable an existing module in the module manager, override a (non-dashboard) module which is one of the ones that provides widgets.. it's also easier to have someone test the related functionality to a module in the dashboard when testing that module than have someone setup and test (effectively) every module in LORIS at the same time for the "dashboard" test.

The tickets came up when I made tickets for the candidate_profile widgets that are missing documentation since the dashboard and candidate_profile use the same getWidgets() function.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @driusan.
Sounds like the Dashboard Readme needs updating with exactly this info, no?

@@ -51,4 +51,6 @@ additional_user_info

- Modifications performed on the MyPreferences page will be reflected on
the user account page when viewing the edited account.
- The user account module registers a widget on the dashboard module to provide
information on the number of accounts that need activation approval.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
information on the number of accounts that need activation approval.
information on the number of accounts that need approval.

I think this is a typo? I don't know what "activation approval" means..

@driusan driusan merged commit 74e49c4 into aces:23.0-release May 4, 2020
@ridz1208 ridz1208 added this to the 23.0.0 milestone May 11, 2020
HenriRabalais pushed a commit to HenriRabalais/Loris that referenced this pull request May 27, 2020
Update of the user account module's README.md and test plan to cover widget registration on the dashboard page.

    Resolves aces#6443
spell00 pushed a commit to spell00/Loris that referenced this pull request Jun 2, 2020
Update of the user account module's README.md and test plan to cover widget registration on the dashboard page.

    Resolves aces#6443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Documentation PR or issue that aims to improve the documentation (test plans, wiki, comments...) Testing PR contains test plan or automated test code (or config files for Travis)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[user_accounts] Widgets not describe in test plan or README
5 participants