Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User account] Update of the README file and test plan. #6464

Merged
merged 2 commits into from
May 4, 2020
Merged

[User account] Update of the README file and test plan. #6464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0325cf6
[User account] Update of the README file and test plan.
nicolasbrossard May 1, 2020
d05cbde
Suggestions made by driusan.
nicolasbrossard May 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions modules/dashboard/test/TestPlan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,32 +46,26 @@
14. Verify that if a user has 'issue_tracker_reporter / issue_tracker_developer' permission,
the issue tracker panel should not be found without this permission.
[Automate Test on Travis_CI]
15. Verify that if a user has 'User Management / Survey Participant Management' permission, the number of pending
account approvals is displayed in the My Task panel. This should be the number of entries in the User Account
page with the following Selection Filter: Site set to the user's site and Pending Approval set to 'Yes'. The
Site displayed will be 'All user sites'. Check that you are taken to that page (with the Selection Filter
correctly set) when you click on the task.
[Automate Test on Travis_CI]
16. Verify that a user with 'Violated Scans: View all-sites Violated Scans' permission has a task with the number
15. Verify that a user with 'Violated Scans: View all-sites Violated Scans' permission has a task with the number
Copy link
Contributor

@christinerogers christinerogers May 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolasbrossard What's the larger discussion about moving all of these widget points under their respective modules? (e.g. violated scans). Has there been a decision that all modules should be doing this?
cc @driusan

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christinerogers Not sure there was a larger discussion regarding this. Dave requested this change: you might want to check with him.

Copy link
Collaborator

@driusan driusan May 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dashboard test plan was written before the module used any widgets, and no longer houses the code being tested. There are many things you can do now which affect what shows up in the dashboard without the dashboard knowing anything about it.. write a new module for a project which has widgets, disable/enable an existing module in the module manager, override a (non-dashboard) module which is one of the ones that provides widgets.. it's also easier to have someone test the related functionality to a module in the dashboard when testing that module than have someone setup and test (effectively) every module in LORIS at the same time for the "dashboard" test.

The tickets came up when I made tickets for the candidate_profile widgets that are missing documentation since the dashboard and candidate_profile use the same getWidgets() function.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @driusan.
Sounds like the Dashboard Readme needs updating with exactly this info, no?

of violated scans displayed. This is the number of entries on the MRI Violated Scans page. The Site displayed will
always be 'All'. Check that clicking on the task takes you to the Violated Scans page.
[Automate Test on Travis_CI]
17. Verify that if a user has the 'View and upload files in Document Repository' or 'Delete files in Document Repository'
16. Verify that if a user has the 'View and upload files in Document Repository' or 'Delete files in Document Repository'
permission, the latest documents to have been edited or uploaded in the document repository are displayed (4 at most)
in the Document Repository panel. Clicking on a document will display it in the browser. Clicking on the Document
Repository button takes you to the Document Repository page.
[Automate Test]
18. Check that if a document notification occurred since the last login, it is labeled as 'New' in the Document
17. Check that if a document notification occurred since the last login, it is labeled as 'New' in the Document
Repository panel.
[Automate Test]
19. Check that a 'New' notification is not labeled 'New' anymore after login in again.
18. Check that a 'New' notification is not labeled 'New' anymore after login in again.
[Manual Test]
20. Check performance on a large dataset (like IBIS) to make sure the dashboard page displays within a reasonable
19. Check performance on a large dataset (like IBIS) to make sure the dashboard page displays within a reasonable
amount of time.
[Manual Test]
21. When there are no candidates registered (i.e. first time install), the system should display a message indicating
20. When there are no candidates registered (i.e. first time install), the system should display a message indicating
that there are no candidates in the DB yet instead of showing the candidates chart.
[Manual Test]
22. When there are no scans done, the system should display a message indicating that no scans were made instead of
21. When there are no scans done, the system should display a message indicating that no scans were made instead of
showing the scans chart.
[Manual Test]
2 changes: 2 additions & 0 deletions modules/user_accounts/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,6 @@ additional_user_info

- Modifications performed on the MyPreferences page will be reflected on
the user account page when viewing the edited account.
- The user account module registers a widget on the dashboard module to provide
information on the number of accounts that need approval.

12 changes: 11 additions & 1 deletion modules/user_accounts/test/TestPlan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,4 +76,14 @@ When creating or editing a user: (subtest: edit_user)
34. See security testing below

##### Security testing:
- Try manipulating the POST request from the browser to add a permission to the editee. Make sure that the editee gets the permission if it is within the set of permissions of the editor Make sure the editee does not get the permission if it is not within the set of permissions of the editor. [See this PR](https://github.com/aces/Loris/pull/3818#issuecomment-408882440) for more details.

35. Try manipulating the POST request from the browser to add a permission to the editee. Make sure that the editee gets the permission if it is within the set of permissions of the editor Make sure the editee does not get the permission if it is not within the set of permissions of the editor. [See this PR](https://github.com/aces/Loris/pull/3818#issuecomment-408882440) for more details.

### Widget registration on the dashboard page

36. Verify that if a user has 'User Management / Survey Participant Management' permission, the number of pending
account approvals is displayed in the My Task panel of the dashboard page. This should be the number of entries
in the User Account page with the following Selection Filter: Site set to the user's site and Pending Approval
set to 'Yes'. The Site displayed will be 'All user sites'. Check that you are taken to that page (with the
Selection Filter correctly set) when you click on the task.
[Automate Test on Travis_CI]