Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mri violation module tabs #8399

Merged
merged 4 commits into from
Mar 14, 2023

Conversation

cmadjar
Copy link
Collaborator

@cmadjar cmadjar commented Feb 21, 2023

Brief summary of changes

This simplifies the MRI violation module to only one table instead of having two tabs. It also allows users to edit the MRI violation resolution instead of having to ask a developer every time a resolution needs to be changed.

Screen Shot 2023-03-07 at 2 14 58 PM

@laemtl laemtl added this to the 25.0.0 milestone Feb 28, 2023
@cmadjar cmadjar marked this pull request as ready for review February 28, 2023 22:07
remove noDynamicDataTable
fix the filter not working for resolution status
update test plan
@cmadjar cmadjar force-pushed the remove_mri_violation_module_tabs branch from 1a8c9d7 to 51e4662 Compare February 28, 2023 22:16
@cmadjar cmadjar self-assigned this Feb 28, 2023
@laemtl laemtl assigned driusan and unassigned cmadjar Mar 7, 2023
@cmadjar cmadjar assigned nicolasbrossard and unassigned driusan Mar 7, 2023
@cmadjar
Copy link
Collaborator Author

cmadjar commented Mar 7, 2023

@nicolasbrossard could you please review/test this? Thank you!!

@cmadjar cmadjar assigned cmadjar and SantiagoTG and unassigned nicolasbrossard Mar 13, 2023
@SantiagoTG
Copy link
Contributor

With regards to the setting the 'Resolution status':

Currently there is no 'Save' button, which means that any selection done is the final selection done for a given image file once the page is closed or refreshed. This is not ideal for two reasons:

  1. It may not be cleat to the user what to do to set the 'Resolution status', leaving the user to figure it out which can lead to naively changing a resolution status thinking nothing will be changed and closing or refreshing the page, leading to erroneous entries.
  2. If the user is scrolling around and inadvertently clicks on a dropdown and changes the setting, the moment you close the page or refresh it, you have no way of reverting the change. This is in opposition to being able to click 'Save', where you confirm or commit to any changes made, giving the user time to review and confirm these (it denotes intention to modify the entries). Thus, having the 'Save' button would be more intuitive and safe.

@driusan
Copy link
Collaborator

driusan commented Mar 14, 2023

Discussed on the LORIS meeting. Will create another issue about the feedback since this is the current behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants