Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataProviders: restriction panels: new toggles and defaults #1390

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from

Conversation

MontrealSergiy
Copy link
Contributor

@MontrealSergiy MontrealSergiy commented May 3, 2024

This aims to enhance the data provider restriction panel with toggles, default buttons, and a ternary checkbox (indeterminate, checked, unchecked states). Unlike the current logic, both whitelisting and blacklisting are employed for greater flexibility. See issue
#1352, #1004, #1430

Note: The previous, more basic attempt (without whitelisting/tristate and default only applying to future data providers and servers) is located in dppolicy. Perhaps, somehow, it can be optimized by incorporating more convoluted logic (keeping default exclusion list rather than black or white list). However, tristate/black-and-white lists seem more efficient in terms of storage space. Additionally, maintaining the exclusion list in a meaningful and robust fashion might require more precautions for exceptions/failures, etc. (which would need further discussion). In particular when policy reversal takes place, in my opinion the exclusion list be replaced with it's compliment. I am concerned that the resulting exclusion logic and code would be even more confusing than the presently suggested ternary approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Features or bugs related to administrative features User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for default data provider policies DataProviders: restriction panels: new toggles and defaults
1 participant