DataProviders: restriction panels: new toggles and defaults #1390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to enhance the data provider restriction panel with toggles, default buttons, and a ternary checkbox (indeterminate, checked, unchecked states). Unlike the current logic, both whitelisting and blacklisting are employed for greater flexibility. See issue
#1352, #1004, #1430
Note: The previous, more basic attempt (without whitelisting/tristate and default only applying to future data providers and servers) is located in dppolicy. Perhaps, somehow, it can be optimized by incorporating more convoluted logic (keeping default exclusion list rather than black or white list). However, tristate/black-and-white lists seem more efficient in terms of storage space. Additionally, maintaining the exclusion list in a meaningful and robust fashion might require more precautions for exceptions/failures, etc. (which would need further discussion). In particular when policy reversal takes place, in my opinion the exclusion list be replaced with it's compliment. I am concerned that the resulting exclusion logic and code would be even more confusing than the presently suggested ternary approach.