update from master #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add xml files for turbine geometry * Add changes for turbine ECal endcap geometry * Add changes for turbine ECal endcap geometry * Different layer numbers for the different wheels * Add segmentation for turbine endcap alorimeter * Add description of the turbine endcap calorimeter * Add comment to changelog * Several optimizations/bug fixes in geometry. Use of boolean shapes is reduced, and +z endcap is mirrored to -z rather than begin recreated. * Several optimizations/bug fixes in geometry. Use of boolean shapes is reduced, and +z endcap is mirrored to -z rather than begin recreated. * Fix geometry bug that excluded the cryostat * Update xml, and make the calibration version consistent --------- Co-authored-by: Erich Varnes <evarnes@atlng01.physics.arizona.edu> Co-authored-by: Brieuc Francois <brieuc.francois@cern.ch>
…from constant defined before in xml (#357)
…ardcoded geometry and add dimensions in xml file
…e, Clarify the units, write detector description
…constructor to remove warnings
* 2nd SIT barrel layer ID corrected; error stemed from outcommenting previous 2nd layer * removed commented layer to avoid any potential issue in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
exactly as it appears between the two bold lines
ENDRELEASENOTES