Tweak GHA configs

[Goooler]

• Bump GH actions, old ones based on Node 16 are deprecated.
• Use Apple silicon images, this will speed up builds on Mac, see https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source
• Merge steps.
• Switch back to ubuntu-latest, now it's 22.04.
• Reuse env variables.

[vit9696]

Please leave 22.04 for stability reasons, we should better upgrade it manually once 24.04 is released and tested.

[Goooler]

655d58a

[vit9696]

Please use a commit corresponding to their latest tag (release). We cannot entirely trust third-party repositories (non-GitHub) are not compromised and get their tags overwritten.

[Goooler]

fa9af0f

[vit9696]

The changes look good to me, would you update other repos or is there no big need in them?

[Goooler]

There are so many repos. I believe we can set up @renovate-bot to keep things up to date for them.

See https://github.com/apps/renovate

[mikebeaton]

Hi - Just as a reminder, if we switch to ARM build runner we should probably remove this: https://github.com/acidanthera/OpenCorePkg/blob/master/build_oc.tool#L328-L336

(Or, if we don't remove it, we will be shipping AARCH64 versions of these couple of BaseTools, which is probably less useful and may confuse people.)

[Goooler]

It could be addressed in a follow-up.

[vit9696]

Ouch, should we really remove that or rather make the tools FAT? In my opinion, should merge after we have a fix for it.

[mikebeaton]

Okay, look for better fix subsequently, for the issue I raised, agreed.

[mikebeaton]

@Goooler - Right, Vit's suggestion was to fix the issue I mentioned, first and then to merge your PR when that is done. So we will look at that, the plan is to do both after next release. Thank you.

[mikebeaton]

I think this should be ready to merge, following acidanthera/audk@33a4015 .

Unfortunately the brew install shellcheck line from analyze.yml workflow is now failing on the M1 runner - presumably this will hit the Intel runner in due course too - because we are hitting this.

I am currently not managing to replicate the error, in order to fix it, using a local, non-container install of brew, even though brew, python3 and pip3 are all the same versions that are causing this to fail in the M1 runner.

Adding --break-system-packages is a possible, but I assume strongly non-preferred, work-around.

[mikebeaton]

Fixed: ab5aeec