BaseTools: Provide fat Mach-O binaries on Darwin #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikebeaton
approved these changes
Mar 27, 2024
mikebeaton
reviewed
Mar 27, 2024
mikebeaton
reviewed
Mar 27, 2024
Comment on lines
132
to
134
| CFLAGS += -arch x86_64 -arch arm64 -mmacosx-version-min=10.13 | ||
| CPPFLAGS += -arch x86_64 -arch arm64 -mmacosx-version-min=10.13 | ||
| LDFLAGS += -arch x86_64 -arch arm64 -mmacosx-version-min=10.13 | ||
| EXTRA_LDFLAGS += -arch x86_64 -arch arm64 -mmacosx-version-min=10.13 |
There was a problem hiding this comment.
Might be (marginally) nicer to still align all the +=?
|
Oh yes, sorry, it really doesn't affect the code at all but I will stick to my story that they are not called 'FAT binary' but 'fat binary' or maybe 'fat-binary' or 'Fat binary' (incl. in Apple usage). (Fat doesn't stand for anything and isn't an acronym, it just means ... fat; hence naming of |
|
Should be done, @mikebeaton, could you merge if it feels good enough after CI? |
vit9696
changed the title
mikebeaton
pushed a commit
that referenced
this pull request
Mar 31, 2024
Merge pull request #63 from acidanthera/vit9696-fattools-20240327
mikebeaton
pushed a commit
to mikebeaton/audk
that referenced
this pull request
Apr 16, 2024
Azure should install code coverage tool (lcov), it didn't exist on Fedora and Ubuntu by default. Update docker setting, pick below solution between 47addc9 and 3b3eb8f 3b3eb8f Fixes and improvements to dev containers (acidanthera#69) 54e5bd1 Enable GTK on Fedora QEMU (acidanthera#63) f1c7a20 Fedora: install code coverage tools for GCC (acidanthera#62) 2ce82af Ubuntu-22: Add initial Ubuntu-22 image (acidanthera#61) 14d2aba Add Fedora 37 image with gcc12 (acidanthera#60) 5b8a008 Add dotnet runtime to fedora build (acidanthera#57) f5c874a Fix platform build file name for EDK2 change (acidanthera#58) 48540ad Ubuntu-20: Fix dev image entrypoint (acidanthera#55) 98e849d Fedora-35: Add Powershell to build image (acidanthera#52) Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Sean Brogan <sean.brogan@microsoft.com> Cc: Michael Kubacki <mikuback@linux.microsoft.com> Cc: Oliver Steffen <osteffen@redhat.com> Cc: Chris Fernald <chfernal@microsoft.com> Signed-off-by: Gua Guo <gua.guo@intel.com> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com> Reviewed-by: Michael Kubacki <mikuback@linux.microsoft.com> Reviewed-by: Chris Fernald <chfernal@microsoft.com>
MikhailKrichanov
pushed a commit
that referenced
this pull request
Jun 27, 2024
Merge pull request #63 from acidanthera/vit9696-fattools-20240327
MikhailKrichanov
pushed a commit
that referenced
this pull request
Jul 1, 2024
Merge pull request #63 from acidanthera/vit9696-fattools-20240327
MikhailKrichanov
pushed a commit
that referenced
this pull request
Jul 1, 2024
Merge pull request #63 from acidanthera/vit9696-fattools-20240327
MikhailKrichanov
pushed a commit
that referenced
this pull request
Jul 18, 2024
Merge pull request #63 from acidanthera/vit9696-fattools-20240327
MikhailKrichanov
pushed a commit
that referenced
this pull request
Jul 22, 2024
Merge pull request #63 from acidanthera/vit9696-fattools-20240327
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
references acidanthera/OpenCorePkg#526