Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Columns and Tag to tsx #1807

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Change Columns and Tag to tsx #1807

merged 4 commits into from
Sep 18, 2024

Conversation

DannielK
Copy link
Collaborator

@DannielK DannielK commented Sep 7, 2024

I accidentally bricked the previous branch so I just made a new one putting in the changes that addressed the comments from the previous PR ( #1762 )

@DannielK DannielK self-assigned this Sep 7, 2024
@DannielK DannielK linked an issue Sep 7, 2024 that may be closed by this pull request
@DannielK
Copy link
Collaborator Author

^^ i had merge conflict from #1813 because he did it on the old Tag.jsx, so I just added what he added to the new Tag.tsx

@shahdivyank shahdivyank merged commit 2eea968 into dev Sep 18, 2024
6 checks passed
@shahdivyank shahdivyank deleted the dk/col_helper_to_ts branch September 18, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript: Columns Helper
2 participants