Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derrick mao/shadcn badge #1813

Merged
merged 4 commits into from
Sep 15, 2024
Merged

Derrick mao/shadcn badge #1813

merged 4 commits into from
Sep 15, 2024

Conversation

Derrick-Mao
Copy link
Collaborator

changed from div to Badge in Tag component
before:
image
after:
image

@Derrick-Mao Derrick-Mao self-assigned this Sep 12, 2024
@Derrick-Mao Derrick-Mao linked an issue Sep 12, 2024 that may be closed by this pull request
@Derrick-Mao
Copy link
Collaborator Author

Error: Tag component's Badge does not reflect mb-2 passed in as classes from form/status,
because the m-0 in Badge's className is overriding the mb-2.

Two options:
move ${classes} to the end of Badge className so its applied after m-0
delete m-0 from Badge className

@Derrick-Mao
Copy link
Collaborator Author

Before:
image
After:
image

@shahdivyank shahdivyank merged commit a878d04 into dev Sep 15, 2024
6 checks passed
@shahdivyank shahdivyank deleted the derrick-mao/shadcn-badge branch September 15, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Shadcn Badges
2 participants