This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Revert "Merge client side and server side configs when installing (#790)" #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
12cdfef
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ae9ad1ec.acorn.pages.dev |
| Branch Preview URL: | https://revert-834-consistent-prompt.acorn.pages.dev |
tylerslaton
approved these changes
Nov 16, 2022
|
replaced by obot-platform/obot#886, which is rebased on main and properly signed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts obot-platform/obot#834
i found a bug with the merging of configs. im going to roll that change back
the config retrieved from the server has default values in it. those defaults should actually be overridden on first install, but pulling them to the client side and merging them in is throwing off the logic
specifically, this is manifesting itself as local.on-acorn.io becoming the cluster domain for installs in the cloud where it should actually be a randomly generated domain name