Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed Katago #173

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Embed Katago #173

wants to merge 4 commits into from

Conversation

bqv
Copy link
Contributor

@bqv bqv commented Oct 14, 2023

This, at best, is my vague attempt at adding katago to the build process, because I had a need to update the binaries bundled in this repository. I've added a module :engines:katago which does build and drop outputs into engines/katago/build/intermediates/cxx/.../..., but I cannot for the life of me figure out yet how to convince gradle to put those into the right place.

It also makes the AI use flows rather than rxjava, and enables the "duringSearch" mechanism now available so the response waits are less jarring for all the AI operations except for makeMove, because that would maybe serve as an unrequested hint.

Goes well nicely with #171

@@ -83,6 +83,11 @@ android {
version "3.10.2"
}
}
sourceSets {
main {
assets.srcDirs += file("${project(":engine:katago").buildDir}/bin")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite, unfortunately

@acristescu
Copy link
Owner

Not sure what you're trying to achieve, is it building katago from source? That would be great, but keep in mind that whatever that guy did that created this binary makes katago very fast on mobile. Any attempt at building from source yielded a binary that was 10 times slower. Sadly, that guy is really annoying and refuses to publish his project open-source, even though he's basically milking katago (which IS open-source).

@bqv
Copy link
Contributor Author

bqv commented Nov 13, 2023

Interesting. Where did you get the binary, out of interest? I haven't noticed much performance penalty unless I use bigger nets, but my phone is quite powerful I guess

@acristescu
Copy link
Owner

acristescu commented Nov 15, 2023

Interesting. Where did you get the binary, out of interest? I haven't noticed much performance penalty unless I use bigger nets, but my phone is quite powerful I guess

@bqv see here: lightvector/KataGo#321

The repo itself is https://github.com/aki65/aki65.github.io the guy is charging $15 for taking an existing open-source Android app (LazyBaduk) and baking open-source Katago into it without even making the build script open-source. At some point he changed something in the protocol so I couldn't get recent versions to work at all.

@francogrex
Copy link

Interesting. Where did you get the binary, out of interest? I haven't noticed much performance penalty unless I use bigger nets, but my phone is quite powerful I guess

@bqv see here: lightvector/KataGo#321

The repo itself is https://github.com/aki65/aki65.github.io the guy is charging $15 for taking an existing open-source Android app (LazyBaduk) and baking open-source Katago into it without even making the build script open-source. At some point he changed something in the protocol so I couldn't get recent versions to work at all.

There is no android katago executable in there.

@acristescu
Copy link
Owner

Interesting. Where did you get the binary, out of interest? I haven't noticed much performance penalty unless I use bigger nets, but my phone is quite powerful I guess

@bqv see here: lightvector/KataGo#321
The repo itself is https://github.com/aki65/aki65.github.io the guy is charging $15 for taking an existing open-source Android app (LazyBaduk) and baking open-source Katago into it without even making the build script open-source. At some point he changed something in the protocol so I couldn't get recent versions to work at all.

There is no android katago executable in there.

Oh, yes there is, but the guy renamed it private.mp3. Of course he did, he's basically stealing. Just go to releases, grab the APK, unzip it, and look into assets. Yeah, that's totally an MP3 he got there, definitely not a stolen copy of katago. 🙄

@francogrex
Copy link

Interesting. Where did you get the binary, out of interest? I haven't noticed much performance penalty unless I use bigger nets, but my phone is quite powerful I guess

@bqv see here: lightvector/KataGo#321
The repo itself is https://github.com/aki65/aki65.github.io the guy is charging $15 for taking an existing open-source Android app (LazyBaduk) and baking open-source Katago into it without even making the build script open-source. At some point he changed something in the protocol so I couldn't get recent versions to work at all.

There is no android katago executable in there.

Oh, yes there is, but the guy renamed it private.mp3. Of course he did, he's basically stealing. Just go to releases, grab the APK, unzip it, and look into assets. Yeah, that's totally an MP3 he got there, definitely not a stolen copy of katago. 🙄

yes I know that the .mp3 is a tgz file but even when you unzip there is no katago in the archive that i can see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants