Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cronjob) Update CronJobs to use stable api in k8s 1.21 #105

Merged
merged 2 commits into from
Apr 1, 2022

Conversation

pedro93
Copy link
Contributor

@pedro93 pedro93 commented Apr 1, 2022

Uses helper methods to detect k8s version being used and changes API spec in CronJob resources accordingly.
Tested locally using minikube with helm dry-runs, cron job warnings no longer appear.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Copy link
Contributor

@anshbansal anshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update of chart version is missing

@pedro93 pedro93 merged commit 558de6b into acryldata:master Apr 1, 2022
MathieuTheerensKlarrio added a commit to klarrio-kpn-rdc/datahub-helm that referenced this pull request Apr 5, 2022
* update actions image tag (acryldata#87)

* update CLI versions (acryldata#88)

* revert version due to regression (acryldata#89)

* Helm Charts 0.8.28 Release (acryldata#91)

* update actions image tag (acryldata#92)

* fix(secrets): Fix secret generation logic (acryldata#93)

* Fix secret generation

* Update secrets

* Helm release for v0.8.30 (acryldata#95)

* Update to v0.8.31 (acryldata#96)

* Explicitly set ui ingestion enabled to false (acryldata#97)

* feat(labels): Add podLabels to Helm charts (acryldata#98)

* Add podLabels to Helm charts

* Ignore IntelliJ .idea folder

* Include datahub-upgrade job specs

* fix: Fix elasticsearch Readiness probe failed (acryldata#99)

* Add enable cache flag (acryldata#102)

* fix(ingress): fix redirect by annotation on k8s >= 1.19 (acryldata#100)

* fix(chart): bump version (acryldata#103)

* fix(cronjob) Update CronJobs to use stable api in k8s 1.21 (acryldata#105)

* Update CronJobs to use stable api in k8s 1.21

* Bumps chart version

* feat(upgrade): Helm release for v0.8.32 (acryldata#106)

* Helm release for v0.8.32

* Fix Job api version

* Upgrade upgrade version

Co-authored-by: Dexter Lee <dexter@acryl.io>

Co-authored-by: Aseem Bansal <asmbansal2@gmail.com>
Co-authored-by: John Joyce <john@acryl.io>
Co-authored-by: Dexter Lee <dexter@acryl.io>
Co-authored-by: Ravindra Lanka <rslanka@gmail.com>
Co-authored-by: Matt Matravers <mattmatravers@hotmail.com>
Co-authored-by: Ebu (えぶ) <eburairu@gmail.com>
Co-authored-by: Felix Bechstein <f@ub0r.de>
Co-authored-by: Pedro Silva <pedro.cls93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants