fix(ui-ingestion): Explicitly set ui ingestion enabled to false when told to do so #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
approved these changes
Mar 18, 2022
MathieuTheerensKlarrio
added a commit
to klarrio-kpn-rdc/datahub-helm
that referenced
this pull request
Apr 5, 2022
* update actions image tag (acryldata#87) * update CLI versions (acryldata#88) * revert version due to regression (acryldata#89) * Helm Charts 0.8.28 Release (acryldata#91) * update actions image tag (acryldata#92) * fix(secrets): Fix secret generation logic (acryldata#93) * Fix secret generation * Update secrets * Helm release for v0.8.30 (acryldata#95) * Update to v0.8.31 (acryldata#96) * Explicitly set ui ingestion enabled to false (acryldata#97) * feat(labels): Add podLabels to Helm charts (acryldata#98) * Add podLabels to Helm charts * Ignore IntelliJ .idea folder * Include datahub-upgrade job specs * fix: Fix elasticsearch Readiness probe failed (acryldata#99) * Add enable cache flag (acryldata#102) * fix(ingress): fix redirect by annotation on k8s >= 1.19 (acryldata#100) * fix(chart): bump version (acryldata#103) * fix(cronjob) Update CronJobs to use stable api in k8s 1.21 (acryldata#105) * Update CronJobs to use stable api in k8s 1.21 * Bumps chart version * feat(upgrade): Helm release for v0.8.32 (acryldata#106) * Helm release for v0.8.32 * Fix Job api version * Upgrade upgrade version Co-authored-by: Dexter Lee <dexter@acryl.io> Co-authored-by: Aseem Bansal <asmbansal2@gmail.com> Co-authored-by: John Joyce <john@acryl.io> Co-authored-by: Dexter Lee <dexter@acryl.io> Co-authored-by: Ravindra Lanka <rslanka@gmail.com> Co-authored-by: Matt Matravers <mattmatravers@hotmail.com> Co-authored-by: Ebu (えぶ) <eburairu@gmail.com> Co-authored-by: Felix Bechstein <f@ub0r.de> Co-authored-by: Pedro Silva <pedro.cls93@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When env is not set, it is defaulted to true, so need to make sure it is explicitly set to false if ui_ingestion is not enabled
Checklist