Skip to content

Text contrast enhanced: Fix passed example 3 not fully passing #1904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 18, 2022

Conversation

WilcoFiers
Copy link
Member

Reported by Kathy. Colors around the "k" in that text dropped below the 7:1 contrast.

Need for Call for Review: 1 week


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

Copy link
Collaborator

@HelenBurge HelenBurge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to remove px and use rem... but that is not something for this PR :)

@WilcoFiers WilcoFiers added the Review Call 1 week Call for review for small changes label Aug 11, 2022
WilcoFiers and others added 2 commits August 18, 2022 13:46
Co-authored-by: giacomo-petri <106394951+giacomo-petri@users.noreply.github.com>
@WilcoFiers WilcoFiers merged commit 70fdc54 into develop Aug 18, 2022
@WilcoFiers WilcoFiers deleted the text-contrast-pass-3-fix branch August 18, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Call 1 week Call for review for small changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants