Correct descriptions of failed examples in valid language tag rule #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Jym77
requested changes
May 30, 2024
| @@ -90,23 +90,23 @@ This `html` element has a `lang` attribute with a [known primary language tag][] | |||
|
|
|||
| #### Failed Example 1 | |||
|
|
|||
| This `html` element has a `lang` attribute with a [known primary language tag][]. | |||
| This `html` element has a `lang` attribute, but it is not a [known primary language tag][]. | |||
There was a problem hiding this comment.
Suggested change
| This `html` element has a `lang` attribute, but it is not a [known primary language tag][]. | |
| This `html` element has a `lang` attribute, with no [known primary language tag][]. |
The value of the lang attribute is not (and does not need to be) a primary language tag, only the, well, primary tag needs to be.
|
|
||
| ```html | ||
| <html lang="em-US"></html> | ||
| ``` | ||
|
|
||
| #### Failed Example 2 | ||
|
|
||
| This `html` element has a `lang` attribute with a [known primary language tag][]. | ||
| This `html` element has a `lang` attribute, but it is not a [known primary language tag][]. |
There was a problem hiding this comment.
Suggested change
| This `html` element has a `lang` attribute, but it is not a [known primary language tag][]. | |
| This `html` element has a `lang` attribute, with no [known primary language tag][]. |
giacomo-petri
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first two failed examples do not have a known primary language tag, and the third example could say "three-letter code."
Need for Call for Review:
This will not require a Call for Review: editorial changes (examples section)
How to Review And Approve