Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Master to Leader #323

Merged
merged 3 commits into from
Feb 20, 2020
Merged

Rename Master to Leader #323

merged 3 commits into from
Feb 20, 2020

Conversation

evantahler
Copy link
Member

@evantahler evantahler commented Feb 20, 2020 •
edited
Loading

closes #315

@evantahler evantahler mentioned this pull request Feb 20, 2020
Closed
@evantahler
Copy link
Member Author

evantahler commented Feb 20, 2020 •
edited
Loading

See #315 for conversation

charlieroth
charlieroth reviewed Feb 20, 2020
View reviewed changes
Copy link
Contributor

@charlieroth charlieroth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Updated effected event handlers from master to leader
  • Updated README.md to reflect the change from master to leader
  • Any changes to import statements are them being reordered via TypeScript Hero
  • Fixed typo in __tests__/utils/specHelper.ts, object was named SpecHeloer, changed to SpecHelper

@evantahler
Copy link
Member Author

Excellent work! Thank you!

@evantahler evantahler merged commit fd436ef into actionhero:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlieroth charlieroth charlieroth left review comments

Assignees
No one assigned
Labels
BREAKING-CHANGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename "master" to "leader"
2 participants
@evantahler @charlieroth