Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the AutoscalingRunnerSet name to runnerScaleSetName #2803

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Set the AutoscalingRunnerSet name to runnerScaleSetName #2803

merged 3 commits into from
Sep 13, 2023

Conversation

hawkesn
Copy link
Contributor

@hawkesn hawkesn commented Aug 9, 2023

Relates to: #2802

This PR helps to rename the AutoscalingRunnerSet name based on the runnerScaleSetName but maintains the backwards compatibility of using the Release.Name if it hasn't been set by the user.

@hawkesn hawkesn requested review from mumoshu, toast-gear, nikola-jokic and a team as code owners August 9, 2023 16:55
@hawkesn hawkesn changed the title AutoscalingRunnerSet name field set to runnerScaleSetName Set the AutoscalingRunnerSet nameto runnerScaleSetName Aug 9, 2023
@hawkesn hawkesn changed the title Set the AutoscalingRunnerSet nameto runnerScaleSetName Set the AutoscalingRunnerSet name to runnerScaleSetName Aug 9, 2023
@nikola-jokic nikola-jokic added this to the gha-runner-scale-set-0.5.1 milestone Aug 21, 2023
@Link- Link- added the gha-runner-scale-set Related to the gha-runner-scale-set mode label Aug 21, 2023
nikola-jokic
nikola-jokic approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@nikola-jokic nikola-jokic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Link- Link- modified the milestones: gha-runner-scale-set-0.5.1, gha-runner-scale-set-0.6.0 Sep 7, 2023
@Link- Link- added the needs testing Requires the e2e tests to pass and/or manual tests to verify label Sep 7, 2023
@nikola-jokic nikola-jokic removed the needs testing Requires the e2e tests to pass and/or manual tests to verify label Sep 13, 2023
@nikola-jokic nikola-jokic merged commit 837a1cb into actions:master Sep 13, 2023
@nikola-jokic nikola-jokic mentioned this pull request Sep 15, 2023
Merged
@booleanbetrayal
Copy link

@nikola-jokic / @hawkesn - I just noticed that the gha-runner-scale-set.labels helper still references .Release.Name. I'm looking / needing this multiple subchart functionality, will this break any discovery or will the sets execute as expected?

@nikola-jokic
Copy link
Collaborator

Hey @booleanbetrayal,

It shouldn't break any functionality ☺️. However, thank you for noticing it! I'll create a PR fixing it for the next patch release.

@booleanbetrayal
Copy link

Thanks for the clarification @nikola-jokic !

@nikola-jokic nikola-jokic mentioned this pull request Sep 21, 2023
Merged
@hawkesn hawkesn deleted the hawkesn/runnerScaleSetName branch September 26, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikola-jokic nikola-jokic nikola-jokic approved these changes

@mumoshu mumoshu Awaiting requested review from mumoshu mumoshu is a code owner

@toast-gear toast-gear Awaiting requested review from toast-gear toast-gear is a code owner

Assignees
No one assigned
Labels
gha-runner-scale-set Related to the gha-runner-scale-set mode
Projects
None yet
Milestone
gha-runner-scale-set-0.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hawkesn @booleanbetrayal @nikola-jokic @Link-