Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name override labels when runnerScaleSetName value is set #2915

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

nikola-jokic
Copy link
Collaborator

Fixing labels applied based on the runnerScaleSetName label.

Fixing missed modification thanks to this comment

@nikola-jokic nikola-jokic requested review from mumoshu, toast-gear and a team as code owners September 21, 2023 11:28
@Link- Link- added the needs triage Requires review from the maintainers label Sep 21, 2023
@nikola-jokic nikola-jokic added the gha-runner-scale-set Related to the gha-runner-scale-set mode label Sep 22, 2023
Copy link
Member

@Link- Link- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship 🚀

@nikola-jokic nikola-jokic merged commit db061b3 into master Sep 26, 2023
@nikola-jokic nikola-jokic deleted the nikola-jokic/fix-chart-labels branch September 26, 2023 09:17
@nikola-jokic nikola-jokic restored the nikola-jokic/fix-chart-labels branch September 26, 2023 09:52
@nikola-jokic nikola-jokic deleted the nikola-jokic/fix-chart-labels branch September 26, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gha-runner-scale-set Related to the gha-runner-scale-set mode needs triage Requires review from the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants