Change minRunners behavior and fix the new listener min runners #3139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikola-jokic
requested review from
mumoshu,
toast-gear and
a team
as code owners
nikola-jokic
added
the
gha-runner-scale-set
Link-
reviewed
Dec 13, 2023
| done | ||
| kubectl wait --timeout=30s --for=condition=ready pod -n arc-systems -l actions.github.com/scale-set-name=$ARC_NAME | ||
| kubectl get pod -n arc-systems | ||
| - name: Ensure 5 runners are up |
There was a problem hiding this comment.
I think this test is not sufficient, what I think the test should do is also to trigger one or more workflow runs and make sure we have 5 runners all the time
Link-
approved these changes
Dec 13, 2023
sergelogvinov
pushed a commit
to sergelogvinov/actions-runner-controller
that referenced
this pull request
Dec 17, 2023
Signed-off-by: Serge Logvinov <serge.logvinov@sinextra.dev>
sergelogvinov
added a commit
to sergelogvinov/actions-runner-controller
that referenced
this pull request
Dec 17, 2023
Signed-off-by: Serge Logvinov <serge.logvinov@sinextra.dev>
sergelogvinov
added a commit
to sergelogvinov/actions-runner-controller
that referenced
this pull request
Dec 17, 2023
Signed-off-by: Serge Logvinov <serge.logvinov@sinextra.dev>
This was referenced Dec 18, 2023
Closed
sergelogvinov
added a commit
to sergelogvinov/actions-runner-controller
that referenced
this pull request
Dec 18, 2023
Signed-off-by: Serge Logvinov <serge.logvinov@sinextra.dev>
nikola-jokic
pushed a commit
that referenced
this pull request
Dec 18, 2023
Merged
Closed
|
@nikola-jokic will this also apply to legacy ARC? i'm guessing not but would it be easy enough to apply there also? |
|
@mumoshu do you think this would be an easy enough change in legacy ARC? happy to help if so... :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the proposed ADR and changes its status.
Target runner count is now calculated as
min(assigned + minRunners, maxRunners)where maxRunners is set to the maximum number that can fit in int32 if not configured.Also, this PR fixes a bug in the new listener that is not yet published, introduced by #3096
Fixes #2707