Fix override listener pod spec (#3139) #3161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergelogvinov
requested review from
mumoshu,
toast-gear,
nikola-jokic and
a team
as code owners
sergelogvinov
changed the title
sergelogvinov
force-pushed
the
listener-template
branch
from
d77d1af to
d46eddc
Compare
| @@ -311,6 +311,8 @@ func mergeListenerPodWithTemplate(pod *corev1.Pod, tmpl *corev1.PodTemplateSpec) | |||
| switch c.Name { | |||
| case "listener": | |||
There was a problem hiding this comment.
Great catch! Can you remove this case because I mistakenly wrote that the container name for the listener is the listener? We don't really need this case anymore
nikola-jokic
added
the
gha-runner-scale-set
nikola-jokic
requested changes
Dec 18, 2023
There was a problem hiding this comment.
Can you please do the following:
- Modify the case to replace
listenerwithautoscalingListenerContainerName - Fix this test also to replace
"listener"with the appropriate variable
Signed-off-by: Serge Logvinov <serge.logvinov@sinextra.dev>
sergelogvinov
force-pushed
the
listener-template
branch
from
d46eddc to
55614ea
Compare
|
@nikola-jokic Done 👍 |
This was referenced Dec 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this small fix.
Thank you @nikola-jokic for you changes. I've checked it, and got small error.
So it will fix it.